Skip to content

Conversation

nathan-weinberg
Copy link
Member

Right now ilab chat greets with Welcome to Chat CLI - I think it may make more sense to be Welcome to InstructLab CLI Chat

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 25, 2024
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @leseb 's suggestion - otherwise lgtm

Co-authored-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Copy link
Contributor

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@russellb russellb merged commit 50f36d4 into instructlab:main Apr 25, 2024
@nathan-weinberg nathan-weinberg deleted the change-greet-text branch April 25, 2024 20:35
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Aug 2, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Aug 2, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Aug 2, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Aug 5, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Aug 6, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Aug 7, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Aug 7, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Aug 19, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Sep 17, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Sep 18, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Sep 18, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fabiendupont added a commit to fabiendupont/instructlab that referenced this pull request Sep 19, 2024
This change modifies the Containerfile for NVIDIA CUDA to:
- Use CentOS Stream 9 as the default base image. UBI9 also works
- Install the NVIDIA packages from NVIDIA repository for exact CUDA version
- Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights...
- Install the Python packages in a Python 3.11 virtualenv
- Install instructlab package from PyPI
- Allow specifying the instructlab version at build time
- Make the final container rootless

Resolves instructlab#899
Replaces instructlab#992
Replaces instructlab#994

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore You gotta do what you gotta do documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants