Prefer https over git and ssh protocols for repo cloning. #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPS has much lower chances to be blocked in certain internal networks as well as more resilient to having issues with changing ssh keys on a GitHub server side. HTTPS is also the default method recommended by GitHub. Passing around ssh keys is also not needed anymore. Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
russellb
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
HTTPS has much lower chances to be blocked in certain internal networks as well as more resilient to having issues with changing ssh keys on a GitHub server side. HTTPS is also the default method recommended by GitHub.
Passing around ssh keys is also not needed anymore.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
SSH access replaced with HTTPS everywhere in docs and the code.
This was originally submitted as #663 , but since the org and the repo got renamed I couldn't re-open that PR, so sending a new one.