config: Prefer https over git and ssh protocols for repo cloning. #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPS has much lower chances to be blocked in certain internal networks as well as more resilient to having issues with changing ssh keys on a GitHub server side. HTTPS is also the default method recommended by GitHub. Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
|
we plan to make these changes when the repos go public. |
|
i will close this for now. feel free to reopen later. |
@xukai92 HTTPS works just fine with authentication via access tokens, which isn't old. But I see how ssh keys can be slightly easier to manage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPS has much lower chances to be blocked in certain internal networks as well as more resilient to having issues with changing ssh keys on a GitHub server side. HTTPS is also the default method recommended by GitHub.
Which issue is resolved by this Pull Request:
I didn't open an issue for this, but the problem I have is that GitHub periodically changes SSH keys and automatic taxonomy clone fails due to a difference with a key in the known hosts file. And I know that there are companies who has git protocol blocked in their internal networks.
Description of your changes:
Changing all git/ssh clone paths to HTTPS.