Test with multiple Python versions #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c904191 to
75efa9e
Compare
booxter
approved these changes
Apr 25, 2024
russellb
approved these changes
Apr 26, 2024
- use `tox-gh` to run tests for each Python env - use `setup-python`'s pip cache Signed-off-by: Christian Heimes <cheimes@redhat.com>
|
I did the rebase. Now CI just needs to run again to make sure it's all still green. |
|
all green! |
russellb
added a commit
to russellb/instructlab
that referenced
this pull request
Apr 29, 2024
When I merged instructlab#984, I failed to ensure the mergify config was updated accordingly to reflect the updated set of test jobs. Signed-off-by: Russell Bryant <rbryant@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Which issue is resolved by this Pull Request:
Resolves #983
Description of your changes:
tox-ghto run tests for each Python envsetup-python's pip cache instead of our own home-grown solution. It's nearly as fast as caching a tox env and less brittle.