Use default context for ensure_server #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21a4c4c to
e7ab33a
Compare
`ensure_server` uses a multiprocessing Process to run a server process. The exit path must wait for the process to finish after `p.terminate()`. Otherwise the parent process might go away before the client can signal the parent that it is gone. Fixes 0c2c459 Signed-off-by: Christian Heimes <cheimes@redhat.com>
russellb
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Which issue is resolved by this Pull Request:
Related to #957
Description of your changes:
Use default multiprocessing default context for
ensure_serverto unblock contributors. For some unknown reasons,spawndoes not work.ensure_serveruses a multiprocessing Process to run a server process. The exit path must wait for the process to finish afterp.terminate(). Otherwise the parent process might go away before the client can signal the parent that it is gone.