Use 'spawn' multiprocessing method instead of fork #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiprocessing uses `fork` as default start method on Linux. Windows and macOS default to `spawn`. The `fork` method is not safe in a multi-threaded environment. It is also incompatible with some hardware accelerators. Use `spawn` on all platforms. Signed-off-by: Christian Heimes <cheimes@redhat.com>
c145862 to
cd8939d
Compare
russellb
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Which issue is resolved by this Pull Request:
Resolves #956
Description of your changes:
Multiprocessing uses
forkas default start method on Linux. Windows and macOS default tospawn. Theforkmethod is not safe in multi-threaded environments. It is also incompatible with some hardware accelerators.Use
spawnon all platforms.