Unbreak CI and add tox -e spellcheck #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 7dffd9e added work `Mixtral`, which is not in the directionary. This broke CI for subsequent PRs. - add `Mixtral` to `.spellcheck-en-custom.txt` - add `make spellcheck-sort` and sort the spell checker file - add `tox -e spellcheck` to detect spelling issues early. Signed-off-by: Christian Heimes <cheimes@redhat.com>
hickeyma
approved these changes
Apr 22, 2024
jgato
pushed a commit
to jgato/instructlab
that referenced
this pull request
Jun 21, 2024
…) (instructlab#1119) Renaming thermo Dir related to instructlab#955 /cc @jjasghar Related to triage call. Signed-off-by: James Labocki <jameslabocki@gmail.com> Signed-off-by: greg pereira <grpereir@redhat.com> Co-authored-by: James Labocki <jameslabocki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Description of your changes:
Commit 7dffd9e added word
Mixtral, which is not in the dictionary. This broke CI for subsequent PRs.Mixtralto.spellcheck-en-custom.txtmake spellcheck-sortand sort the spell checker filetox -e spellcheckto detect spelling issues early.