Refactor the CUDA container spec #932
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the Containerfile for NVIDIA CUDA to: - use the CUDA runtime image for the final stage - install the Python packages in a virtualenv that is copied in the final container - make the final container rootless It also proposes a shell alias that should simplify the user experience when using the container image, avoiding to use long `podman run` commands. It modifies the containerization documentation to explain all of this and provide steps for the user. The `cuda` target in the Makefile is modified accordingly. Signed-off-by: Fabien Dupont <fdupont@redhat.com>
ac1a38a to
febb15c
Compare
|
@fabiendupont can you rebase this when you get a chance? |
|
Closing in favor of #934 |
mergify bot
added a commit
that referenced
this pull request
Sep 19, 2024
This change modifies the Containerfile for NVIDIA CUDA to: - Use CentOS Stream 9 as the default base image. UBI9 also works - Install the NVIDIA packages from NVIDIA repository for exact CUDA version - Add NVIDIA scripts from `nvcr.io/nvidia/cuda` image for copyrights... - Install the Python packages in a Python 3.11 virtualenv - Install instructlab package from PyPI - Allow specifying the instructlab version at build time - Make the final container rootless Resolves #899 Replaces #932 Replaces #994 Approved-by: nathan-weinberg Approved-by: markstur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the Containerfile for NVIDIA CUDA to:
Propose a shell alias that should simplify the user experience when using the container image, avoiding using long
podman runcommands.Modify the containerization documentation to explain this and provide steps for the user.
Update the
cudatarget in the Makefile to reflect the changes above.Resolves #899