Skip to content

Changing from instruct-lab to instructlab #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Changing from instruct-lab to instructlab #895

wants to merge 2 commits into from

Conversation

jjasghar
Copy link
Member

  • fixed some instruct-lab to instructlab
  • stable tag doesn't seem to exist.

@jjasghar
Changing from instruct-lab to instructlab
1179267 
- fixed some instruct-lab to instructlab
- stable tag doesn't seem to exist.

Signed-off-by: JJ Asghar <awesome@ibm.com>
@jjasghar
wrong version of python
e01208c 
my version of python was wrong here.

Signed-off-by: JJ Asghar <awesome@ibm.com>
@tiran
Copy link
Contributor

tiran commented Apr 18, 2024

This appears to duplicate some of #887 . @russellb 's PR addresses the entire code base.

@hickeyma
Copy link
Member

Thanks for pushing PR @jjasghar but closing in favor of #887 as it has more complete changes.

@hickeyma hickeyma closed this Apr 18, 2024
@hickeyma hickeyma mentioned this pull request Apr 18, 2024
Merged
@hickeyma hickeyma deleted the jjasghar-patch-1 branch April 18, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairin mairin Awaiting requested review from mairin

@kelbrown20 kelbrown20 Awaiting requested review from kelbrown20

@jeremyeder jeremyeder Awaiting requested review from jeremyeder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjasghar @tiran @hickeyma