Reflect new repo name #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been updated for the new github org name as well |
oindrillac
reviewed
Apr 17, 2024
| @@ -2,14 +2,14 @@ | |||
|
|
|||
| This guide should teach you how to set up your development environment to start contributing to the `ilab` CLI tool. | |||
|
|
|||
| **tl;dr** We're going to install `ilab` in a Python virtual environment like we did in the `README.md`. Instead of installing from GitHub, however, we'll clone the [`instruct-lab/cli`](https://github.com/instruct-lab/cli) repository from GitHub and install `ilab` from the cloned Python source code. | |||
| **tl;dr** We're going to install `ilab` in a Python virtual environment like we did in the `README.md`. Instead of installing from GitHub, however, we'll clone the [`instructlab/instructlab`](https://github.com/instruct-lab/cli) repository from GitHub and install `ilab` from the cloned Python source code. | |||
There was a problem hiding this comment.
should this be (https://github.com/instructlab/cli)?
There was a problem hiding this comment.
good catch! You caught a bug in my one-liner!
git grep 'github.com/instruct-lab' | cut -f1 -d':' | sort -u | xargs sed -i -e 's/github.com\/instruct-lab/github.com\/instructlab/'
needs to be
git grep 'github.com/instruct-lab' | cut -f1 -d':' | sort -u | xargs sed -i -e 's/github.com\/instruct-lab/github.com\/instructlab/g'
There was a problem hiding this comment.
Suggested change
| **tl;dr** We're going to install `ilab` in a Python virtual environment like we did in the `README.md`. Instead of installing from GitHub, however, we'll clone the [`instructlab/instructlab`](https://github.com/instruct-lab/cli) repository from GitHub and install `ilab` from the cloned Python source code. | |
| **tl;dr** We're going to install `ilab` in a Python virtual environment like we did in the `README.md`. Instead of installing from GitHub, however, we'll clone the [`instructlab/instructlab`](https://github.com/instructlab/instructlab) repository from GitHub and install `instructlab` package with `ilab` command line tool from the cloned Python source code. |
tiran
approved these changes
Apr 17, 2024
The `cli` repo is now `instructlab`. Issue #817 Signed-off-by: Russell Bryant <rbryant@redhat.com>
This was referenced Apr 18, 2024
|
Thats a good point @tiran. |
hickeyma
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 44d193d
Author: Russell Bryant rbryant@redhat.com
Date: Wed Apr 17 13:40:35 2024 -0400
#817