(tests) Add tests for knowledge docs #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02b0fc6 to
16f1a25
Compare
xukai92
reviewed
Apr 11, 2024
bjhargrave
reviewed
Apr 11, 2024
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
@xukai92 @bjhargrave dissected the changes into multiple commits, PTAL! |
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
xukai92
reviewed
Apr 15, 2024
bjhargrave
requested changes
Apr 15, 2024
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
bjhargrave
approved these changes
Apr 16, 2024
jgato
pushed a commit
to jgato/instructlab
that referenced
this pull request
Jun 21, 2024
Description: Removing old file spelling error file Signed-off-by: Kelly Brown <kelbrown@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #786
Which issue is resolved by this Pull Request:
Resolves #786
Description of your changes:
This PR:
generate_data.pytoutils,py. Several other packges (egdiff) are using these helper functions(egread_taxonomy), and they were calling generate.<helper_function>, which is incorrect.utils.py, but is restricted to only the helper functions used during knowledge workflow.generate_datawith knowledge workflow.