Simplify generation code #688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d791e9 to
0d41952
Compare
0d41952 to
638fcb1
Compare
638fcb1 to
5b0de29
Compare
The post_process_gpt3_response function takes a lot of params that we don't use and returns a format we need to convert. Because of this we're looping on datastructures for no reason. Remove it to simplify generation code. Fixes: #485 Signed-off-by: Derek Higgins <derekh@redhat.com>
5b0de29 to
2c281cc
Compare
|
Re-opened here #931 |
jgato
pushed a commit
to jgato/instructlab
that referenced
this pull request
Jun 21, 2024
Signed-off-by: Dan McPherson <dmcphers@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The post_process_gpt3_response function takes a lot of params that we don't use and returns a format we need to convert. Because of this we're looping on
datastructures for no reason. Remove it to simplify generation code.
Fixes: #485