Skip to content

do not print exceptions from the server when running the server with ilab chat #937

@leseb

Description

@leseb

When simply running ilab chat, if no server is running locally, a temporary one will run as a child process from the main CLI call. If during the execution of the chat an exception is raised it's stracktraces in the chat. That is not a good user experience, especially given that exceptions are handled correctly by the chat main process.

Example:

(venv) [leseb@tarox~/cli][fix-911] ilab chat
INFO 2024-04-19 15:02:43,561 _base_client.py:1039 Retrying request to /models in 0.992545 seconds
INFO 2024-04-19 15:02:44,556 _base_client.py:1039 Retrying request to /models in 1.745032 seconds
INFO 2024-04-19 15:02:47,552 _client.py:1026 HTTP Request: GET http://localhost:40882/v1/models "HTTP/1.1 200 OK"
╭─────────────────────────────────────────────────────── system ────────────────────────────────────────────────────────╮
│ Welcome to Chat CLI w/ MODELS/MERLINITE-7B-Q4_K_M.GGUF (type /h for help)                                             │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
>>> hello                                                                                                    [S][default]
INFO 2024-04-19 15:02:53,896 _client.py:1026 HTTP Request: POST http://localhost:40882/v1/chat/completions "HTTP/1.1 200 OK"
╭─────────────────────────────────────────── models/merlinite-7b-Q4_K_M.gguf ───────────────────────────────────────────╮
╭─────────────────────────────────────────── models/merlinite-7b-Q4_K_M.gguf ───────────────────────────────────────────╮
│ Hello! I'                                                                                                             │
╰─────────────────────────────────────────────────────────────────────────────────────────────── elapsed 0.575 seconds ─╯
>>> disconnected                                                                                             [S][default]
Disconnected from client (via refresh/close) Address(host='::1', port=53334)

See the message:

disconnected                                                                                             [S][default]
Disconnected from client (via refresh/close) Address(host='::1', port=53334)

which is returned by the app running inside uvicorn.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions