fix: avoid printing errors from the server in the chat #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leseb needs a rebase now - but thank you for the fixes! |
9679a7d to
966c9c6
Compare
Done, thanks! |
966c9c6 to
09f67cc
Compare
russellb
requested changes
Apr 24, 2024
There was a problem hiding this comment.
This lgtm, but I'm not going to merge since @alimaredia self-requesteed a review
russellb
approved these changes
Apr 24, 2024
739f9c5 to
0eeccf7
Compare
When an error occurs in the chat, we don't want to surface the whole server stacktrace but let the chat handle the exception and return a proper message. Here is an example: ``` ilab chat ╭────────────────────────────────────────────────────────── system ──────────────────────────────────────────────────────────╮ │ Welcome to Chat CLI w/ MERLINITE-7B-LAB-Q4_K_M (type /h for help) │ ╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ >>> hello [S][default] Message too large for context size. ``` We just print the relevant information and hide the internal server exception. Fixes: instructlab#937 Signed-off-by: Sébastien Han <seb@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error occurs in the chat, we don't want to surface the whole
server stacktrace but let the chat handle the exception and return a
proper message.
Here is an example:
We just print the relevant information and hide the internal server
exception.
Fixes: #937
Signed-off-by: Sébastien Han seb@redhat.com
ON-TOP of #925. Let's merge #925 first.