Support float16 and bfloat16 embedding data type #1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
046e31a to
d497e2f
Compare
fe193b3 to
3fa5e99
Compare
3fa5e99 to
b3e5582
Compare
3 tasks
JinHai-CN
added a commit
that referenced
this pull request
Aug 5, 2024
…1588) ### What problem does this PR solve? Fix bug for bit, float16 and bfloat16 embedding type Add python test for float16 and bfloat16 embedding type Fix #1579 ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) - [x] Refactoring - [x] Test cases --------- Co-authored-by: Jin Hai <haijin.chn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support float16 and bfloat16 embedding data type
Type of change