chore: remove error check after command flag get #3976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking errors is not required because flag values are initially validated on execution while setting the string values.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3976 +/- ##
==========================================
+ Coverage 24.78% 24.91% +0.12%
==========================================
Files 296 296
Lines 24915 24792 -123
==========================================
Hits 6176 6176
+ Misses 18172 18049 -123
Partials 567 567
|
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
* chore: remove error check after command flag get Checking errors is not required because flag values are initially validated on execution while setting the string values. * chore: update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking errors is not required because flag values are initially validated on execution while setting the string values.
Closes #1101