feat: add include feature to the chain config file #4638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 796e7f6): https://igntservices-docs--pr4638-feat-include-config-xfktzpeh.web.app (expires Thu, 01 May 2025 06:04:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5 |
|
This feature is awesome! I'll take time to properly review after the break. |
julienrbrt
previously approved these changes
Apr 22, 2025
julienrbrt
approved these changes
Apr 24, 2025
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
* feat: add include feature to the chain config file * improve logic * fix wrong var * add changlog * fix lint * fix lint and improve readbility * fix lint and add comments * fix comments --------- Co-authored-by: julienrbrt <julien@rbrt.fr> (cherry picked from commit af6b115) # Conflicts: # ignite/config/chain/base/config.go # ignite/config/chain/parse.go # ignite/config/chain/parse_test.go
julienrbrt
added a commit
that referenced
this pull request
Apr 24, 2025
…4650) * feat: add include feature to the chain config file (#4638) * feat: add include feature to the chain config file * improve logic * fix wrong var * add changlog * fix lint * fix lint and improve readbility * fix lint and add comments * fix comments --------- Co-authored-by: julienrbrt <julien@rbrt.fr> (cherry picked from commit af6b115) # Conflicts: # ignite/config/chain/base/config.go # ignite/config/chain/parse.go # ignite/config/chain/parse_test.go * fix conflicts * go mod tidy --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
|
Great , amazing work. Its documented well: https://docs.ignite.com/references/config#include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4527
Description
In your main
config.yml, use theincludefield to reference other local or remote YAML files.It allows you to split your chain configuration across multiple files, making it easier to manage and reuse configuration parts.
Include remote files via URL or server path are also valid:
Common Use Cases:
Split your config into a base setup and an external
accounts.ymlfor better separation of concerns:config.ymlaccounts.yml