feat: support custom proto path #4071
Conversation
There was a problem hiding this comment.
changes lgtm but I don't understand the use case tbh.
We should actually move towards having protos directly hosted in the modules instead.
like f.e: https://github.com/cosmos/cosmos-sdk/tree/main/x/bank/proto
this feature won't less us easily do that later on.
@julienrbrt, We already support a custom proto path in the chain's |
This feature can also be changed in the future so we can support a custom module dir inside the module folder |
if you think it is worth it to support that level of customizability, then fine 👍🏾 |
* support custom proto path * add changelog * check buf work proto * check if the buf.work.yaml has the same proto path from the config file * add comments * rmeove unused code * remove unused proto paths and add integrations tests * fix resolve includes function * fix integration tests * scaffold a list into the tests * proto dir flag * avoid read config for scaffold commands * fix wrong embed path * scaffold a chain with a custom proto path * fix proto-dir flag * fix protoDir var for plush files * fix buf pkg * fix unit tests for buf files * add proto dir to scaffold chain * fix wrong prodir for the module * fix wrong proto dir * fix text scaffold conflits * fix wront proto path --------- Co-authored-by: Pantani <Pantani>
* support custom proto path * add changelog * check buf work proto * check if the buf.work.yaml has the same proto path from the config file * add comments * rmeove unused code * remove unused proto paths and add integrations tests * fix resolve includes function * fix integration tests * scaffold a list into the tests * proto dir flag * avoid read config for scaffold commands * fix wrong embed path * scaffold a chain with a custom proto path * fix proto-dir flag * fix protoDir var for plush files * fix buf pkg * fix unit tests for buf files * add proto dir to scaffold chain * fix wrong prodir for the module * fix wrong proto dir * fix text scaffold conflits * fix wront proto path --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 6364ecb) # Conflicts: # go.mod # ignite/cmd/chain.go # ignite/cmd/cmd.go # ignite/cmd/scaffold.go # ignite/cmd/scaffold_chain.go # ignite/cmd/scaffold_configs.go # ignite/cmd/scaffold_message.go # ignite/cmd/scaffold_module.go # ignite/cmd/scaffold_package.go # ignite/cmd/scaffold_params.go # ignite/cmd/scaffold_query.go # ignite/config/chain/base/config.go # ignite/config/chain/parse.go # ignite/config/chain/v1/config.go # ignite/config/chain/v1/config_test.go # ignite/config/chain/v1/validator_servers.go # ignite/pkg/cosmosgen/generate.go # ignite/services/chain/proto.go # ignite/services/chain/serve.go # ignite/services/scaffolder/configs.go # ignite/services/scaffolder/init.go # ignite/services/scaffolder/message.go # ignite/services/scaffolder/module.go # ignite/services/scaffolder/packet.go # ignite/services/scaffolder/params.go # ignite/services/scaffolder/query.go # ignite/services/scaffolder/scaffolder.go # ignite/services/scaffolder/type.go # ignite/templates/app/files/proto/buf.gen.pulsar.yaml # ignite/templates/app/files/{{protoDir}}/buf.gen.pulsar.yaml # ignite/templates/app/files/{{protoDir}}/buf.gen.pulsar.yaml.plush # ignite/templates/app/proto.go # ignite/templates/module/create/configs.go # ignite/templates/module/create/options.go # ignite/templates/module/create/params.go
close #3979
close #4007
Description
Create a
proto-dirflag for scaffold commands to use a different proto directory. This PR also manages thebuf.work.yamlto be populated automatics depending on your proto directory