fix(xgenny): run all dry runners before the wet run in the xgenny pkg
#4000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgenny pkg
xgenny pkgxgenny pkg
jeronimoalbi
approved these changes
Mar 5, 2024
|
I am not super familiar with this part of the codebase @Pantani, but do you suggest this is something that should get backported or we leave it for v29? |
|
Would be good to backport imo. |
|
I think is not necessary, we can hold for the 29 if we are going to release it soon |
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
…kg (#4000) * run all dry runners before the we runners for the xgenny pkg * add changelog --------- Co-authored-by: Pantani <Pantani>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, we run a dry run, and after the wet run, for each modification. We should run the dry runner before all modifications so we can run the wet runner.