Skip to content

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 8, 2024

Description

  • Remove all ignite placeholder into the .plush imports and add them using the xast.AppendImports function;
  • Remove the keeper definition placeholder into the app.go.plush and add them using the xast.ModifyFunction function;
  • Remove unused placeholders;

@Pantani Pantani self-assigned this Mar 8, 2024
@Pantani Pantani changed the title feat: remove all import placeholders feat: remove all import placeholders using the xast pkg Mar 8, 2024
@Pantani Pantani marked this pull request as ready for review March 8, 2024 02:39
@Pantani Pantani marked this pull request as draft March 8, 2024 02:49
@Pantani Pantani marked this pull request as ready for review March 8, 2024 06:16
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

love the imports' replacement, but a bit less the magic look of the keeper addition.

@Pantani Pantani enabled auto-merge (squash) March 8, 2024 18:57
@Pantani Pantani merged commit 59400a5 into main Mar 8, 2024
@Pantani Pantani deleted the feat/remove-import-placeholders branch March 8, 2024 19:55
julienrbrt pushed a commit that referenced this pull request May 29, 2024
* remove all import placeholders

* add changelog

* remove unused placeholders

* fix wrong import path

* improve readbility

* remove keeper definition placeholder

---------

Co-authored-by: Pantani <Pantani>
@Pantani Pantani added the backport/v28.x.y Backport to v28.x.y label Jul 2, 2024
mergify bot pushed a commit that referenced this pull request Jul 2, 2024
* remove all import placeholders

* add changelog

* remove unused placeholders

* fix wrong import path

* improve readbility

* remove keeper definition placeholder

---------

Co-authored-by: Pantani <Pantani>
(cherry picked from commit 59400a5)

# Conflicts:
#	ignite/templates/ibc/placeholders.go
@Pantani Pantani removed the backport/v28.x.y Backport to v28.x.y label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants