fix: allow build version to be set from ldflags #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Awesome! Thanks. I guess this clarifies #80 too. |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
May 13, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [idursun/jjui](https://github.com/idursun/jjui) | patch | `v0.8.7` -> `v0.8.8` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>idursun/jjui (idursun/jjui)</summary> ### [`v0.8.8`](https://github.com/idursun/jjui/releases/tag/v0.8.8) [Compare Source](idursun/jjui@v0.8.7...v0.8.8) Everything from [0.8.7](https://github.com/idursun/jjui/releases/tag/v0.8.7) #### What's Changed - fix: allow build version to be set from ldflags by [@​lvignoli](https://github.com/lvignoli) in idursun/jjui#81 #### Experimental log batching I've added an experimental feature that loads revisions in batches and request the next batch only if the cursor goes beyond the last loaded revision. This should greatly improve the loading times, reduce the memory footprint and essentially make `jjui` usable with huge repositories. I have done my best to hide this behind a configuration flag which can be enabled by adding the following to your configuration file: ```toml experimental_log_batching_enabled = true ``` #### New Contributors - [@​lvignoli](https://github.com/lvignoli) made their first contribution in idursun/jjui#81 **Full Changelog**: idursun/jjui@v0.8.7...v0.8.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xMS43IiwidXBkYXRlZEluVmVyIjoiNDAuMTEuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building from a standalone VCS-free tarball of the repo, info.Main.Version is
(devel), not"".This fix first check if main.Version has been set by the build options, then default to get the version info embedded by go.
This is necessary for #72.