fix: add missing hasResources check #3182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iBotPeaches
approved these changes
Jul 20, 2023
iBotPeaches
added a commit
that referenced
this pull request
Jul 20, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a missing check for hasResources in ApkDecoder, which causes minSdkVersion to be force-replaced for APKs also, not just for JARs, which often causes an inconsistency with the original APK.
As such, the hasResources of ResourcesDecoder must be public (ideally "package-private", but ResourcesDecoder is in "res" sub-package so that is not viable).
Also made hasManifest public for consistency's sake to avoid confusion and open it for possible usage in ApkDecoder in the future.