Skip to content

refactor class ApkDecoder #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2023
Merged

refactor class ApkDecoder #3106

merged 1 commit into from
Jun 28, 2023

Conversation

sv99
Copy link
Contributor

@sv99 sv99 commented Jun 28, 2023 •
edited
Loading

  1. Rename methods which copy data from decodeXXX to copyXXX
  2. Make copy and decode methods private - used from decode()
  3. move methods which initialized MetaInfo to the class ResTable

@sv99 sv99 force-pushed the refactor_apkdecoder branch from e9a8455 to 817f241 Compare June 28, 2023 09:00
@sv99 sv99 force-pushed the refactor_apkdecoder branch from 817f241 to d19de59 Compare June 28, 2023 09:12
@iBotPeaches iBotPeaches merged commit 85a710f into iBotPeaches:master Jun 28, 2023
iBotPeaches added a commit that referenced this pull request Jun 28, 2023
@iBotPeaches
docs: updated for #3106
ac3454b
@iBotPeaches
Copy link
Owner

thanks!

@iBotPeaches iBotPeaches added this to the v2.8.0 milestone Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iBotPeaches iBotPeaches iBotPeaches approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sv99 @iBotPeaches