Don't try to get an Undefined bokeh property #3513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3513 +/- ##
==========================================
- Coverage 82.80% 82.80% -0.01%
==========================================
Files 199 199
Lines 27296 27305 +9
==========================================
+ Hits 22603 22610 +7
- Misses 4693 4695 +2
Continue to review full report at Codecov.
|
|
Looks good to me. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3512
The
DatePickerwidget has in Panel aparam.CalendarDateParameter that allows None, however in the Bokeh model theDateproperty isn'tNullable(which I imagine could be improved). When a PanelDatePickeris instantiated without definingvalue, and thenvalueis set to a date, the Bokeh model doesn't havevalueyet defined, which causes the error reported in the issue. The suggested change catches the error raised by Bokeh and assumes the property is effectively going to change, since it was not set at all.