Require plugin name #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍻 |
jdx
pushed a commit
that referenced
this pull request
Jun 19, 2018
Bring in `certs:auto` from heroku-certs-acm
jdx
pushed a commit
that referenced
this pull request
Jun 19, 2018
* Add `heroku ci:run` command * Add #createTestRun to Heroku API * Add temp dependency * wip: heroku ci:run * Use title line from the last commit message for run * Remove quotation marks from commit message parse * Remove unused variable declarations * Clean up generator syntax on run function
RasPhilCo
added a commit
that referenced
this pull request
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin name was not required when using topic commands, causing panic if missing, as the empty string was not caught.
i.e.
heroku plugins:installInitially looked at putting code in cli.go, however the line in parseArgs with the loop followed by switch case for checking args has no sensible way to check for the (usually optional) absence of args:
for i := 0; i < len(args); i++ {Another solution might be to add an additional check in cli.go, for the length of additional args (for topics that require it). Empty strings will likely cause further bugs.