bugfix: Override subcharts with null values #12879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c40879 to
ba1bf8b
Compare
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
ba1bf8b to
5a58751
Compare
|
When this could be merged? |
|
Please merge/release ASAP. All builds from 3.13 onwards are "effectively" broken for many of my clients because of this. |
|
I hope to see this in the next Helm release, there are many workarounds used to overcome this bug. |
|
I think this is also related #12991 |
|
Beep boop we need this, boop beep |
|
Ahh, alas, another week goes by, and yet more DevOps engineers are fraught with this unnecessary pain in having to continue to use such an old version of Helm without this bug. Beep boop, someone merge and release this, boop beep. |
|
Another week nudge on this. Sorry to be the annoying jerk, but this is important. |
This was referenced Jun 7, 2024
|
Sorry to go against etiquette here with comment spam but we're also affected by this bug, and with this PR waiting for review for almost 3 months now I think some of us might be losing hope :-) |
|
Just collecting all the duplicate bugs about this over the years, for fun I guess... #12991 #12741 #12730 #12637 #12594 #12522 #12511 #12490 #12488 #12469 #12441 #12417 #11567 #9806 #9804 #9696 #9136 #9027 #6277 #5184 I'm so happy that the helm devs keep this bug alive so that I can charge my clients hours in working around it. Thanks! Tonight I eat steak thanks to you! On a more serious note, who can we ping about this? I see @mattfarina worked on #12480 , sorry for the rude ping but maybe you were at least aware of the issue at some point in time. |
|
I'd like to join the ping party, even though I know it won't help and normally I'd consider it rude as well, but this is getting ridiculous. Even if this is merged it will be some time until tools like argo-cd picks it up so that things can finally go back to the way they were. Anyone with merge rights on this repo please take a look, lots of people would appreciate it ❤️ |
|
Hmm, can we just start aggressively @-ing owners and/or higher tier contributors on this repo? I feel like maybe this thread has been muted, and maybe we have no choice. I don't mention brute force lightly, but this is a serious issue which has gone unchecked for too long. |
|
This PR fixes a really inconvenient bug and is highly expected to be merge. |
This was referenced Jan 24, 2025
|
@ryanhockstad thank you! |
|
📣 Backport PR #13654 merged 👏 This fix is scheduled to be in Helm 3.17.1 |
mattfarina
pushed a commit
that referenced
this pull request
Feb 12, 2025
- Add consistency for null test in given values, parent chart, subchart, and sub-sub-chart - Remove bar null test to keep consistent with boat=null at top level Signed-off-by: Scott Rigby <scott@r6by.com> (cherry picked from commit 60fcce1)
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 13, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [helm/helm](https://github.com/helm/helm) | patch | `v3.17.0` -> `v3.17.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>helm/helm (helm/helm)</summary> ### [`v3.17.1`](https://github.com/helm/helm/releases/tag/v3.17.1): Helm v3.17.1 [Compare Source](helm/helm@v3.17.0...v3.17.1) Helm v3.17.1 is a patch release. Users are encouraged to upgrade for the best experience. Users are encouraged to upgrade for the best experience. The community keeps growing, and we'd love to see you there! - Join the discussion in [Kubernetes Slack](https://kubernetes.slack.com): - for questions and just to hang out - for discussing MRs, code, and bugs - Hang out at the Public Developer Call: Thursday, 9:30 Pacific via [Zoom](https://zoom.us/j/696660622) - Test, debug, and contribute charts: [ArtifactHub/packages](https://artifacthub.io/packages/search?kind=0) #### Installation and Upgrading Download Helm v3.17.1. The common platform binaries are here: - [MacOS amd64](https://get.helm.sh/helm-v3.17.1-darwin-amd64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.17.1-darwin-amd64.tar.gz.sha256sum) / aba59ba9511971a71943b5c76f15d52ace1681197bb3f71ed1f0b15caceacb2c) - [MacOS arm64](https://get.helm.sh/helm-v3.17.1-darwin-arm64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.17.1-darwin-arm64.tar.gz.sha256sum) / b823a213d8d7937222becc63d9c7bb3d15a090e7ecd1f70f3a583ed39657e21b) - [Linux amd64](https://get.helm.sh/helm-v3.17.1-linux-amd64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.17.1-linux-amd64.tar.gz.sha256sum) / 3b66f3cd28409f29832b1b35b43d9922959a32d795003149707fea84cbcd4469) - [Linux arm](https://get.helm.sh/helm-v3.17.1-linux-arm.tar.gz) ([checksum](https://get.helm.sh/helm-v3.17.1-linux-arm.tar.gz.sha256sum) / 1dc5ed54350f4f7ae87441e878be4f4fd9b727a86b11b1d20b1001358c83bed3) - [Linux arm64](https://get.helm.sh/helm-v3.17.1-linux-arm64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.17.1-linux-arm64.tar.gz.sha256sum) / c86c9b23602d4abbfae39d9634e25ab1d0ea6c4c16c5b154113efe316a402547) - [Linux i386](https://get.helm.sh/helm-v3.17.1-linux-386.tar.gz) ([checksum](https://get.helm.sh/helm-v3.17.1-linux-386.tar.gz.sha256sum) / b972562a1171673db2892f000248b2540ddcd6f76850ec152852a8e9ce7972cb) - [Linux ppc64le](https://get.helm.sh/helm-v3.17.1-linux-ppc64le.tar.gz) ([checksum](https://get.helm.sh/helm-v3.17.1-linux-ppc64le.tar.gz.sha256sum) / 4223394f3fca82a7f8e8d083caf6faf0ee0639d8f235071334579237078a2c2e) - [Linux s390x](https://get.helm.sh/helm-v3.17.1-linux-s390x.tar.gz) ([checksum](https://get.helm.sh/helm-v3.17.1-linux-s390x.tar.gz.sha256sum) / fe47e5ee8abd6baef01bb1c4fc995343121bf5fc7dead1f67e97484a441ba9e8) - [Linux riscv64](https://get.helm.sh/helm-v3.17.1-linux-riscv64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.17.1-linux-riscv64.tar.gz.sha256sum) / cf174b1ff83032255f798278152c637d01dd1d1533fd77915ab751d8cf4191a7) - [Windows amd64](https://get.helm.sh/helm-v3.17.1-windows-amd64.zip) ([checksum](https://get.helm.sh/helm-v3.17.1-windows-amd64.zip.sha256sum) / 08281ee6d4d272835ff10c510b8b39736d112d9cb89dfbc853fe83913fbe48d0) - [Windows arm64](https://get.helm.sh/helm-v3.17.1-windows-arm64.zip) ([checksum](https://get.helm.sh/helm-v3.17.1-windows-arm64.zip.sha256sum) / 44c9c8246f643ea45bb45013a182fc25da2a8206a6f322a0c6fa47a1f4bcf1e4) The [Quickstart Guide](https://helm.sh/docs/intro/quickstart/) will get you going from there. For **upgrade instructions** or detailed installation notes, check the [install guide](https://helm.sh/docs/intro/install/). You can also use a [script to install](https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3) on any system with `bash`. #### What's Next - 3.17.2 is the next patch release and will be on March 12, 2025 - 3.18.0 is the next minor release and will be on May 14, 2025 #### Changelog - add test for nullifying nested global value [`980d8ac`](helm/helm@980d8ac) (Ryan Hockstad) - Add test case for removing an entire object [`c23e3b6`](helm/helm@c23e3b6) (Ryan Hockstad) - Tests for bugfix: Override subcharts with null values [#​12879](helm/helm#12879) [`3110d5f`](helm/helm@3110d5f) (Scott Rigby) - merge null child chart objects [`9520c71`](helm/helm@9520c71) (Ryan Hockstad) - build(deps): bump the k8s-io group with 7 updates [`ab7dedd`](helm/helm@ab7dedd) (dependabot\[bot]) - fix: check group for resource info match [`a2d3602`](helm/helm@a2d3602) (Jiasheng Zhu) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjYuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE2Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
krajorama
added a commit
to grafana/mimir
that referenced
this pull request
Apr 7, 2025
helm/helm#12879 modified merging values for sub-charts in a non-backwards compatible way. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2 tasks
aknuds1
pushed a commit
to grafana/mimir
that referenced
this pull request
Apr 7, 2025
* fix(helm): followup PR 12879 in Helm helm/helm#12879 modified merging values for sub-charts in a non-backwards compatible way. * update Helm version in CI --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
lelithium
added a commit
to iotile/helm
that referenced
this pull request
Apr 28, 2025
* Move gjenkins to maintainer Signed-off-by: George Jenkins <gvjenkins@gmail.com> * Bump golang/govulncheck-action from 1.0.3 to 1.0.4 Bumps [golang/govulncheck-action](https://github.com/golang/govulncheck-action) from 1.0.3 to 1.0.4. - [Release notes](https://github.com/golang/govulncheck-action/releases) - [Commits](https://github.com/golang/govulncheck-action/compare/dd0578b371c987f96d1185abb54344b44352bd58...b625fbe08f3bccbe446d94fbf87fcc875a4f50ee) --- updated-dependencies: - dependency-name: golang/govulncheck-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the k8s-io group with 7 updates Bumps the k8s-io group with 7 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.31.0` | `0.31.1` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.31.0` | `0.31.1` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.31.0` | `0.31.1` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.31.0` | `0.31.1` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.31.0` | `0.31.1` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.31.0` | `0.31.1` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.31.0` | `0.31.1` | Updates `k8s.io/api` from 0.31.0 to 0.31.1 - [Commits](https://github.com/kubernetes/api/compare/v0.31.0...v0.31.1) Updates `k8s.io/apiextensions-apiserver` from 0.31.0 to 0.31.1 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.31.0...v0.31.1) Updates `k8s.io/apimachinery` from 0.31.0 to 0.31.1 - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.31.0...v0.31.1) Updates `k8s.io/apiserver` from 0.31.0 to 0.31.1 - [Commits](https://github.com/kubernetes/apiserver/compare/v0.31.0...v0.31.1) Updates `k8s.io/cli-runtime` from 0.31.0 to 0.31.1 - [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.31.0...v0.31.1) Updates `k8s.io/client-go` from 0.31.0 to 0.31.1 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.31.0...v0.31.1) Updates `k8s.io/kubectl` from 0.31.0 to 0.31.1 - [Commits](https://github.com/kubernetes/kubectl/compare/v0.31.0...v0.31.1) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com> * updating owners file Signed-off-by: Robert Sirchia <rsirchia@outlook.com> * Bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.1.0 to 6.1.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](https://github.com/golangci/golangci-lint-action/compare/aaa42aa0628b4ae2578232a66b541047968fac86...971e284b6050e8a5849b72094c50ab08da042db8) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Revering change unrelated to issue #13176 Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de> * Bump golang.org/x/crypto from 0.27.0 to 0.28.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.28.0. - [Commits](https://github.com/golang/crypto/compare/v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: Use chart archive modifed time for OCI push Signed-off-by: George Jenkins <gvjenkins@gmail.com> * verbs Signed-off-by: George Jenkins <gvjenkins@gmail.com> * Move jdolitsky to emeritus * Doc: add Flox as an installation option. Amending for new checks to run. Signed-off-by: Bryan Honof <bryan@floxdev.com> Signed-off-by: Robert Sirchia <rsirchia@outlook.com> * Bump actions/checkout from 4.2.0 to 4.2.1 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/d632683dd7b4114ad314bca15554477dd762a938...eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore: Make retryingRoundTripper type public Make retryingRoundTripper type public to allow being used in other projects fixes: #13052 Signed-off-by: Luis Davim <luis.davim@gmail.com> * chore(deps): bump actions/stale from 3.0.14 to 9.0.0 Bumps [actions/stale](https://github.com/actions/stale) from 3.0.14 to 9.0.0. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/stale/compare/v3.0.14...v9.0.0) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/cyphar/filepath-securejoin from 0.3.1 to 0.3.4 Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.1 to 0.3.4. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md) - [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.3.1...v0.3.4) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore: Add Evans to OWNERS file Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Reorder triage ids Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Bump github.com/containerd/containerd from 1.7.12 to 1.7.23 Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.12 to 1.7.23. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](https://github.com/containerd/containerd/compare/v1.7.12...v1.7.23) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * minor spelling fix Signed-off-by: Jon Olsson <jon.olsson@sequitor.se> * fix(helm): Retry Conflict error for createResource, deleteResource kubernetes might at any time throw 409 Conflict Error codes. Clients are supposed to retry when this happens. As an example, see kubernetes/issues/67761 where such an issues might happen when the cluster manipulates a projects's ResourceQuotas. Catch such Conflict Errors on createResource and deleteResource and retry before giving up. Due to the more complex logic and focus on kubernetes/issues/67761, this patch purposefully omits possibly needed changes to updateResource and instead defers them to another patch if required in the future. Closes issue #9710 Signed-off-by: Andreas Karis <ak.karis@gmail.com> * adding test coverage for ready.go Signed-off-by: Robert Sirchia <rsirchia@outlook.com> * Cleanup redundant GO11MODULE Signed-off-by: George Jenkins <gvjenkins@gmail.com> * adding more unit test Signed-off-by: Robert Sirchia <rsirchia@outlook.com> * chore: Check tar is installed install script Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Remove unnecessary function arguments Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Fix failing tests Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Ensure test fails without causing panic Signed-off-by: Evans Mungai <mbuevans@gmail.com> * fixing unit test as per Matt Signed-off-by: Robert Sirchia <rsirchia@outlook.com> * removing duplicate empty test Signed-off-by: Robert Sirchia <rsirchia@outlook.com> * Bump the k8s-io group with 7 updates Bumps the k8s-io group with 7 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.31.1` | `0.31.2` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.31.1` | `0.31.2` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.31.1` | `0.31.2` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.31.1` | `0.31.2` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.31.1` | `0.31.2` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.31.1` | `0.31.2` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.31.1` | `0.31.2` | Updates `k8s.io/api` from 0.31.1 to 0.31.2 - [Commits](https://github.com/kubernetes/api/compare/v0.31.1...v0.31.2) Updates `k8s.io/apiextensions-apiserver` from 0.31.1 to 0.31.2 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.31.1...v0.31.2) Updates `k8s.io/apimachinery` from 0.31.1 to 0.31.2 - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.31.1...v0.31.2) Updates `k8s.io/apiserver` from 0.31.1 to 0.31.2 - [Commits](https://github.com/kubernetes/apiserver/compare/v0.31.1...v0.31.2) Updates `k8s.io/cli-runtime` from 0.31.1 to 0.31.2 - [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.31.1...v0.31.2) Updates `k8s.io/client-go` from 0.31.1 to 0.31.2 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.31.1...v0.31.2) Updates `k8s.io/kubectl` from 0.31.1 to 0.31.2 - [Commits](https://github.com/kubernetes/kubectl/compare/v0.31.1...v0.31.2) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com> * chore: fix some function names in comment Signed-off-by: wangjingcun <wangjingcun@aliyun.com> * Bump actions/setup-go from 5.0.2 to 5.1.0 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.2 to 5.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32...41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/checkout from 4.2.1 to 4.2.2 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871...11bd71901bbe5b1630ceea73d27597364c9af683) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Allow tests to run on loong64 Signed-off-by: Tianle Xu <xtl@xtlsoft.top> * fix(hooks): correct hooks delete order Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> * Increasing the size of the runner used for releases. Note, this runner is provided as part of the CNCF access to GitHub Enterprise runners. Signed-off-by: Matt Farina <matt.farina@suse.com> * Fix typo in pkg/lint/rules/chartfile_test.go Signed-off-by: Zach Burgess <zachburg@google.com> * Add tests to `helm/pkg/kube/client_test.go` to cover `wait.go` Signed-off-by: Alex Johnson <alex.kattathra.johnson@gmail.com> * Updating subchart load error to be more descriptive In the event some malformed folders/files make its way into the `charts/` directory meant for subcharts, it is possible one may see an error message like the below: ``` Error: error unpacking foo in app: Chart.yaml file is missing ``` This error is not very descriptive, as it doesn't reference where on disk `Chart.yaml` is missing. In the event this happens, this error is being updated to include that `Chart.yaml` is missing for the `foo` subchart. Without this updated error messaging, one would need to look into Helm's codebase to troubleshoot what exactly is wrong. Signed-off-by: Taylor Jasko <taylor@taylorjasko.com> * fix: fix label name Signed-off-by: wangjingcun <wangjingcun@aliyun.com> * Bump golang.org/x/crypto from 0.28.0 to 0.29.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.28.0 to 0.29.0. - [Commits](https://github.com/golang/crypto/compare/v0.28.0...v0.29.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Adding CI for dev-v3 branch When the main branch is for Helm v4, the dev-v3 branch is for Helm v3. Note, the canary release is setup for helm v4 once the v3 branch is created and there is no canary release for v3. Signed-off-by: Matt Farina <matt.farina@suse.com> * Add --take-ownership flag for install and upgrade commands The `TakeOwnership` setting was added to the install and upgrade actions in https://github.com/helm/helm/pull/12876 This PR allows setting this option on install and upgrade via the CLI using a --take-ownership flag Signed-off-by: Mayank Shah <mayankshah1614@gmail.com> * Update cmd/helm/install.go Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Mayank Shah <mayankshah1614@gmail.com> * Update cmd/helm/upgrade.go Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Mayank Shah <mayankshah1614@gmail.com> * Rename CAFile to CaFile for consistency Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Make the authorizer and registry authorizer configurable Fixes: #12584 This change makes the authorizer and registryAuthorizer of the registry client configurable via options. This allows Go SDK users to override the authentication behavior of the client. This PR makes both the authorizer and registryAuthorizer configurable because depending on the exact scenario that may be needed. The default registryAuthorizer only supports a specific implementation of the authorizer. Signed-off-by: Ryan Nowak <nowakra@gmail.com> * Shadow ORAS remote.Client interface Signed-off-by: George Jenkins <gvjenkins@gmail.com> * fix upgrade Signed-off-by: Mayank Shah <mayankshah1614@gmail.com> * fix test Signed-off-by: Mayank Shah <mayankshah1614@gmail.com> * fix test output Signed-off-by: Mayank Shah <mayankshah1614@gmail.com> * Bump the k8s-io group with 7 updates Bumps the k8s-io group with 7 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.31.2` | `0.31.3` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.31.2` | `0.31.3` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.31.2` | `0.31.3` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.31.2` | `0.31.3` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.31.2` | `0.31.3` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.31.2` | `0.31.3` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.31.2` | `0.31.3` | Updates `k8s.io/api` from 0.31.2 to 0.31.3 - [Commits](https://github.com/kubernetes/api/compare/v0.31.2...v0.31.3) Updates `k8s.io/apiextensions-apiserver` from 0.31.2 to 0.31.3 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.31.2...v0.31.3) Updates `k8s.io/apimachinery` from 0.31.2 to 0.31.3 - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.31.2...v0.31.3) Updates `k8s.io/apiserver` from 0.31.2 to 0.31.3 - [Commits](https://github.com/kubernetes/apiserver/compare/v0.31.2...v0.31.3) Updates `k8s.io/cli-runtime` from 0.31.2 to 0.31.3 - [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.31.2...v0.31.3) Updates `k8s.io/client-go` from 0.31.2 to 0.31.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.31.2...v0.31.3) Updates `k8s.io/kubectl` from 0.31.2 to 0.31.3 - [Commits](https://github.com/kubernetes/kubectl/compare/v0.31.2...v0.31.3) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 4872c724c5393c8ce9e5ee45c8f7afde5637826c) * Bump golang.org/x/crypto from 0.30.0 to 0.31.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.30.0 to 0.31.0. - [Commits](https://github.com/golang/crypto/compare/v0.30.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 194d989b235cf6f5821f068ce5ba81c55eb6be2f) * This commit fixes the issue where the yaml.Unmarshaller converts all int values into float64, this passes in option to decoder, which enables conversion of int into . Signed-off-by: Althaf M <althafm@outlook.com> * Bump github.com/containerd/containerd from 1.7.23 to 1.7.24 Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.23 to 1.7.24. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](https://github.com/containerd/containerd/compare/v1.7.23...v1.7.24) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](https://github.com/stretchr/testify/compare/v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/cyphar/filepath-securejoin from 0.3.4 to 0.3.6 Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.4 to 0.3.6. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md) - [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.3.4...v0.3.6) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/rubenv/sql-migrate from 1.7.0 to 1.7.1 Bumps [github.com/rubenv/sql-migrate](https://github.com/rubenv/sql-migrate) from 1.7.0 to 1.7.1. - [Commits](https://github.com/rubenv/sql-migrate/compare/v1.7.0...v1.7.1) --- updated-dependencies: - dependency-name: github.com/rubenv/sql-migrate dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Fix dev-v3 from take ownership changes When #13531 was merged in the tests were not passing. This is because it took into account #13444 but that had not been backported to v3. Tests had not been automatically run on dev-v3 but that was fixed via #13563. Signed-off-by: Matt Farina <matt.farina@suse.com> * Run `build-test` action on `dev-v3` branch Signed-off-by: George Jenkins <gvjenkins@gmail.com> (cherry picked from commit bfada38aa9e1cf85e3a8241a3060a0dd8423d24f) * Add annotations and dependencies to get metadata output The output of helm get metadata includes a subset of the fields contained in the chart.Metadata struct. This change adds the values of the annotations field and the dependencies field to the output. Signed-off-by: Niladri Halder <niladri.halder26@gmail.com> * ref(create): don't render empty resource fields Signed-off-by: Denis Krivenko <dnskrv88@gmail.com> Signed-off-by: dnskr <dnskrv88@gmail.com> * Update to Go 1.23 Multiple changes were made to pass linting. Some Go built-in names are being used for variables (e.g., min). This happens in the Go source itself including the Go standard library and is not always a bad practice. To handle allowing some built-in names to be used the linter config is updated to allow (via opt-in) some names to pass. This allows us to still check for re-use of Go built-in names and opt-in to any new uses. There were also several cases where a value was checked for nil before checking its length when this is already handled by len() or the types default value. These were cleaned up. The license validation was updated because it was checking everything in the .git directory including all remote content that was local. The previous vendor directory was from a time prior to Go modules when Helm handled dependencies differently. It was no longer needed. Signed-off-by: Matt Farina <matt.farina@suse.com> (cherry picked from commit 5727f56a967418f9254f3604789547b5d7509260) * Update golangci-lint version Signed-off-by: Matt Farina <matt.farina@suse.com> (cherry picked from commit 66f84e510e12edbc02ad0e102ca17ad3edfd53e3) * Upgrade golang.org/x/net to v0.33.0 to address CVE-2024-45338 fixed: #13551 Signed-off-by: cx <1249843194@qq.com> (cherry picked from commit e00ab86567cd91562b63f396a30818d1020a84c1) * Bump the k8s-io group with 7 updates Bumps the k8s-io group with 7 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.31.3` | `0.32.0` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.31.3` | `0.32.0` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.31.3` | `0.32.0` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.31.3` | `0.32.0` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.31.3` | `0.32.0` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.31.3` | `0.32.0` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.31.3` | `0.32.0` | Updates `k8s.io/api` from 0.31.3 to 0.32.0 - [Commits](https://github.com/kubernetes/api/compare/v0.31.3...v0.32.0) Updates `k8s.io/apiextensions-apiserver` from 0.31.3 to 0.32.0 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.31.3...v0.32.0) Updates `k8s.io/apimachinery` from 0.31.3 to 0.32.0 - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.31.3...v0.32.0) Updates `k8s.io/apiserver` from 0.31.3 to 0.32.0 - [Commits](https://github.com/kubernetes/apiserver/compare/v0.31.3...v0.32.0) Updates `k8s.io/cli-runtime` from 0.31.3 to 0.32.0 - [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.31.3...v0.32.0) Updates `k8s.io/client-go` from 0.31.3 to 0.32.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.31.3...v0.32.0) Updates `k8s.io/kubectl` from 0.31.3 to 0.32.0 - [Commits](https://github.com/kubernetes/kubectl/compare/v0.31.3...v0.32.0) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com> * feat: allow installation by OCI digest Signed-off-by: Terry Howe <terrylhowe@gmail.com> (cherry picked from commit ad9fb68fa3911979ccaba1e230a8043971b84042) * fix: issue with helm template and oci chart Signed-off-by: Terry Howe <terrylhowe@gmail.com> (cherry picked from commit aca7e8d775a3674b41d989ac5be263236273be7b) * fix: make ORAS reference private Signed-off-by: Terry Howe <terrylhowe@gmail.com> (cherry picked from commit d2b94f62004e79864ec530989109cf0effd4aaae) * feat: Added multi-platform plugin hook support to v3 Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com> * Tests for bugfix: Override subcharts with null values #12879 - Add consistency for null test in given values, parent chart, subchart, and sub-sub-chart - Remove bar null test to keep consistent with boat=null at top level Signed-off-by: Scott Rigby <scott@r6by.com> * Add test case for removing an entire object Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com> * Bump github.com/moby/term from 0.5.0 to 0.5.2 Bumps [github.com/moby/term](https://github.com/moby/term) from 0.5.0 to 0.5.2. - [Commits](https://github.com/moby/term/compare/v0.5.0...v0.5.2) --- updated-dependencies: - dependency-name: github.com/moby/term dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * bump version to v3.17.0 Signed-off-by: Matt Farina <matt.farina@suse.com> (cherry picked from commit 301108edc7ac2a8ba79e4ebf5701b0b6ce6a31e4) * Bump golang.org/x/term from 0.27.0 to 0.28.0 Bumps [golang.org/x/term](https://github.com/golang/term) from 0.27.0 to 0.28.0. - [Commits](https://github.com/golang/term/compare/v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/crypto from 0.31.0 to 0.32.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.31.0 to 0.32.0. - [Commits](https://github.com/golang/crypto/compare/v0.31.0...v0.32.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/containerd/containerd from 1.7.24 to 1.7.25 Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.24 to 1.7.25. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](https://github.com/containerd/containerd/compare/v1.7.24...v1.7.25) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Ensuring the file paths are clean prior to passing to securejoin securejoin v0.4.0 made a possibly breaking change. Only clean paths are safe to pass to SecureJoin or they could return an error or have the wrong path. The details are in the release notes for v0.4.0. This change ensures the paths are clean prior to passing to SecureJoin. Signed-off-by: Matt Farina <matt.farina@suse.com> (cherry picked from commit 35a9ead99872f2cbee84922f2538e687fe14d8a9) * add test for nullifying nested global value Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com> * Bump github.com/cyphar/filepath-securejoin from 0.3.6 to 0.4.0 Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.3.6 to 0.4.0. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md) - [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.3.6...v0.4.0) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: check group for resource info match Closes: #13582 Signed-off-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com> (cherry picked from commit f5d488122b20374161c724ea1b1254ef628d02e3) * build(deps): bump the k8s-io group with 7 updates Bumps the k8s-io group with 7 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.0` | `0.32.1` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.0` | `0.32.1` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.32.0` | `0.32.1` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.32.0` | `0.32.1` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.32.0` | `0.32.1` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.0` | `0.32.1` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.32.0` | `0.32.1` | Updates `k8s.io/api` from 0.32.0 to 0.32.1 - [Commits](https://github.com/kubernetes/api/compare/v0.32.0...v0.32.1) Updates `k8s.io/apiextensions-apiserver` from 0.32.0 to 0.32.1 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.32.0...v0.32.1) Updates `k8s.io/apimachinery` from 0.32.0 to 0.32.1 - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.32.0...v0.32.1) Updates `k8s.io/apiserver` from 0.32.0 to 0.32.1 - [Commits](https://github.com/kubernetes/apiserver/compare/v0.32.0...v0.32.1) Updates `k8s.io/cli-runtime` from 0.32.0 to 0.32.1 - [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.32.0...v0.32.1) Updates `k8s.io/client-go` from 0.32.0 to 0.32.1 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.32.0...v0.32.1) Updates `k8s.io/kubectl` from 0.32.0 to 0.32.1 - [Commits](https://github.com/kubernetes/kubectl/compare/v0.32.0...v0.32.1) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/evanphx/json-patch Bumps [github.com/evanphx/json-patch](https://github.com/evanphx/json-patch) from 5.9.0+incompatible to 5.9.11+incompatible. - [Release notes](https://github.com/evanphx/json-patch/releases) - [Commits](https://github.com/evanphx/json-patch/compare/v5.9.0...v5.9.11) --- updated-dependencies: - dependency-name: github.com/evanphx/json-patch dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/cyphar/filepath-securejoin Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.4.0 to 0.4.1. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Changelog](https://github.com/cyphar/filepath-securejoin/blob/main/CHANGELOG.md) - [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.4.0...v0.4.1) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/spf13/pflag from 1.0.5 to 1.0.6 Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](https://github.com/spf13/pflag/compare/v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: github.com/spf13/pflag dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump golang.org/x/text from 0.21.0 to 0.22.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.21.0 to 0.22.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](https://github.com/golang/text/compare/v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump golang.org/x/term from 0.28.0 to 0.29.0 Bumps [golang.org/x/term](https://github.com/golang/term) from 0.28.0 to 0.29.0. - [Commits](https://github.com/golang/term/compare/v0.28.0...v0.29.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump golang.org/x/crypto from 0.32.0 to 0.33.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.32.0 to 0.33.0. - [Commits](https://github.com/golang/crypto/compare/v0.32.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump the k8s-io group with 7 updates Bumps the k8s-io group with 7 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.1` | `0.32.2` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.1` | `0.32.2` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.32.1` | `0.32.2` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.32.1` | `0.32.2` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.32.1` | `0.32.2` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.1` | `0.32.2` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.32.1` | `0.32.2` | Updates `k8s.io/api` from 0.32.1 to 0.32.2 - [Commits](https://github.com/kubernetes/api/compare/v0.32.1...v0.32.2) Updates `k8s.io/apiextensions-apiserver` from 0.32.1 to 0.32.2 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.32.1...v0.32.2) Updates `k8s.io/apimachinery` from 0.32.1 to 0.32.2 - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.32.1...v0.32.2) Updates `k8s.io/apiserver` from 0.32.1 to 0.32.2 - [Commits](https://github.com/kubernetes/apiserver/compare/v0.32.1...v0.32.2) Updates `k8s.io/cli-runtime` from 0.32.1 to 0.32.2 - [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.32.1...v0.32.2) Updates `k8s.io/client-go` from 0.32.1 to 0.32.2 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.32.1...v0.32.2) Updates `k8s.io/kubectl` from 0.32.1 to 0.32.2 - [Commits](https://github.com/kubernetes/kubectl/compare/v0.32.1...v0.32.2) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com> * Moving to SetOut and SetErr for Cobra SetOutput is deprecated. This causes it to fail linting. Signed-off-by: Matt Farina <matt@mattfarina.com> (cherry picked from commit b689ff203e76cf009f931dcec49910c6054c06b3) * build(deps): bump github.com/spf13/cobra from 1.8.1 to 1.9.1 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.1 to 1.9.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](https://github.com/spf13/cobra/compare/v1.8.1...v1.9.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/distribution/distribution/v3 Bumps [github.com/distribution/distribution/v3](https://github.com/distribution/distribution) from 3.0.0-20221208165359-362910506bc2 to 3.0.0-rc.3. - [Release notes](https://github.com/distribution/distribution/releases) - [Commits](https://github.com/distribution/distribution/commits/v3.0.0-rc.3) --- updated-dependencies: - dependency-name: github.com/distribution/distribution/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * feat: Add flags to enable CPU and memory profiling Add capability to profile cli command using https://go.dev/blog/pprof Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Additional review fixes from PR Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Update CONTRIBUTING.md Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Move pprof paths to HELM_PPROF env variable Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Fix linter warning Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Prefer environment variables to CLI flags Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Update CONTRIBUTING guide Signed-off-by: Evans Mungai <mbuevans@gmail.com> * chore: update profiling doc in CONTRIBUTING.md Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Update cmd/helm/profiling.go Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Evans Mungai <mbuevans@gmail.com> * chore: use []error instead of []string Signed-off-by: Evans Mungai <mbuevans@gmail.com> * Add hook annotations to output pod logs to client on success and fail Signed-off-by: Chris Berry <bez625@gmail.com> * Tidy up imports Signed-off-by: Chris <bez625@gmail.com> * Fix lint Signed-off-by: Chris Berry <bez625@gmail.com> * Update based on review comments Signed-off-by: Chris Berry <bez625@gmail.com> * Update based on review comments Signed-off-by: Chris Berry <bez625@gmail.com> * add short circuit return Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> * remove comments about previous functionality Signed-off-by: Scott Rigby <scott@r6by.com> * fix err check Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> * clarify fix error message Signed-off-by: Scott Rigby <scott@r6by.com> * Add HookOutputFunc and generic yaml unmarshaller Signed-off-by: Chris Berry <bez625@gmail.com> * Refactor based on review comment Signed-off-by: Chris Berry <bez625@gmail.com> * Refactor based on review comment Signed-off-by: Chris Berry <bez625@gmail.com> * Fix cherry-pick helm.sh/helm/v4 -> helm.sh/helm/v3 Signed-off-by: Scott Rigby <scott@r6by.com> * build(deps): bump golang.org/x/crypto from 0.33.0 to 0.35.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.33.0 to 0.35.0. - [Commits](https://github.com/golang/crypto/compare/v0.33.0...v0.35.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/containerd/containerd from 1.7.25 to 1.7.26 Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.25 to 1.7.26. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](https://github.com/containerd/containerd/compare/v1.7.25...v1.7.26) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/opencontainers/image-spec Bumps [github.com/opencontainers/image-spec](https://github.com/opencontainers/image-spec) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/opencontainers/image-spec/releases) - [Changelog](https://github.com/opencontainers/image-spec/blob/main/RELEASES.md) - [Commits](https://github.com/opencontainers/image-spec/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: github.com/opencontainers/image-spec dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump golang.org/x/crypto from 0.35.0 to 0.36.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.35.0 to 0.36.0. - [Commits](https://github.com/golang/crypto/compare/v0.35.0...v0.36.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump the k8s-io group with 7 updates Bumps the k8s-io group with 7 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.2` | `0.32.3` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.2` | `0.32.3` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.32.2` | `0.32.3` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.32.2` | `0.32.3` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.32.2` | `0.32.3` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.2` | `0.32.3` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.32.2` | `0.32.3` | Updates `k8s.io/api` from 0.32.2 to 0.32.3 - [Commits](https://github.com/kubernetes/api/compare/v0.32.2...v0.32.3) Updates `k8s.io/apiextensions-apiserver` from 0.32.2 to 0.32.3 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.32.2...v0.32.3) Updates `k8s.io/apimachinery` from 0.32.2 to 0.32.3 - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.32.2...v0.32.3) Updates `k8s.io/apiserver` from 0.32.2 to 0.32.3 - [Commits](https://github.com/kubernetes/apiserver/compare/v0.32.2...v0.32.3) Updates `k8s.io/cli-runtime` from 0.32.2 to 0.32.3 - [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.32.2...v0.32.3) Updates `k8s.io/client-go` from 0.32.2 to 0.32.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.32.2...v0.32.3) Updates `k8s.io/kubectl` from 0.32.2 to 0.32.3 - [Commits](https://github.com/kubernetes/kubectl/compare/v0.32.2...v0.32.3) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com> * Updating to 0.37.0 for x/net This is due to a CVE present in the current version. Dependabot has stopped making PRs for x/net so this is created due to that. An issue was filed to look in to the dependabot issue. Signed-off-by: Matt Farina <matt.farina@suse.com> (cherry picked from commit 667a5b733804960ea3f49d4566847db81def27ab) * chore(oci): upgrade to ORAS v2 Signed-off-by: Terry Howe <terrylhowe@gmail.com> * automatic fallback to http Signed-off-by: Terry Howe <terrylhowe@gmail.com> * Update pkg/registry/fallback.go Signed-off-by: Terry Howe <terrylhowe@gmail.com> * build(deps): bump github.com/containerd/containerd from 1.7.26 to 1.7.27 Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.26 to 1.7.27. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](https://github.com/containerd/containerd/compare/v1.7.26...v1.7.27) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Report as debug log, the time spent waiting for resources Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * Fix typo Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * Unarchiving fix Signed-off-by: Matt Farina <matt@mattfarina.com> (cherry picked from commit 7cc4dcf94ee410c8e0d64f3e726dda199c24ccb2) * Bumps github.com/distribution/distribution/v3 from 3.0.0-rc.3 to 3.0.0 ``` $ go mod download 130 ↵ go: module github.com/distribution/distribution/v3@v3.0.0 requires go >= 1.23.7; switching to go1.23.8 ``` Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * Permit more Go version and not only 1.23.8 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * Testing text bump Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * build(deps): bump golang.org/x/term from 0.30.0 to 0.31.0 Bumps [golang.org/x/term](https://github.com/golang/term) from 0.30.0 to 0.31.0. - [Commits](https://github.com/golang/term/compare/v0.30.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-version: 0.31.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump golang.org/x/crypto from 0.36.0 to 0.37.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.36.0 to 0.37.0. - [Commits](https://github.com/golang/crypto/compare/v0.36.0...v0.37.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.37.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/rubenv/sql-migrate from 1.7.1 to 1.7.2 Bumps [github.com/rubenv/sql-migrate](https://github.com/rubenv/sql-migrate) from 1.7.1 to 1.7.2. - [Commits](https://github.com/rubenv/sql-migrate/compare/v1.7.1...v1.7.2) --- updated-dependencies: - dependency-name: github.com/rubenv/sql-migrate dependency-version: 1.7.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Fix --take-ownership If a resource exists in the cluster and is to be adopted by helm install --take-ownership, it is left unchanged while helm reports the installation to have succeeded. This is due to CRs and CRDs being merged without three-way-merge, which results in an empty patch. By using a three-way-merge transparently when --take-ownership is used, the helm behaves as expected without breaking previous behavior. Fixes #30622 Signed-off-by: Patrick Seidensal <pseidensal@suse.com> * Add install test for TakeOwnership flag Signed-off-by: Evans Mungai <mbuevans@gmail.com> * build(deps): bump github.com/rubenv/sql-migrate from 1.7.2 to 1.8.0 Bumps [github.com/rubenv/sql-migrate](https://github.com/rubenv/sql-migrate) from 1.7.2 to 1.8.0. - [Commits](https://github.com/rubenv/sql-migrate/compare/v1.7.2...v1.8.0) --- updated-dependencies: - dependency-name: github.com/rubenv/sql-migrate dependency-version: 1.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * backport #30677to dev3 Signed-off-by: dongjiang <dongjiang1989@126.com> * Bump toml Looking at the [toml diff](https://github.com/BurntSushi/toml/compare/v1.4.0...v1.5.0). I think it's safe to change the test here. For main: https://github.com/helm/helm/pull/30775 Closes: https://github.com/helm/helm/pull/30683 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * Bump net package to avoid CVE on dev-v3 Closes: #30780 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> --------- Signed-off-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Robert Sirchia <rsirchia@outlook.com> Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de> Signed-off-by: Bryan Honof <bryan@floxdev.com> Signed-off-by: Luis Davim <luis.davim@gmail.com> Signed-off-by: Evans Mungai <mbuevans@gmail.com> Signed-off-by: Jon Olsson <jon.olsson@sequitor.se> Signed-off-by: Andreas Karis <ak.karis@gmail.com> Signed-off-by: wangjingcun <wangjingcun@aliyun.com> Signed-off-by: Tianle Xu <xtl@xtlsoft.top> Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> Signed-off-by: Matt Farina <matt.farina@suse.com> Signed-off-by: Zach Burgess <zachburg@google.com> Signed-off-by: Alex Johnson <alex.kattathra.johnson@gmail.com> Signed-off-by: Taylor Jasko <taylor@taylorjasko.com> Signed-off-by: Mayank Shah <mayankshah1614@gmail.com> Signed-off-by: Ryan Nowak <nowakra@gmail.com> Signed-off-by: Althaf M <althafm@outlook.com> Signed-off-by: Niladri Halder <niladri.halder26@gmail.com> Signed-off-by: Denis Krivenko <dnskrv88@gmail.com> Signed-off-by: dnskr <dnskrv88@gmail.com> Signed-off-by: cx <1249843194@qq.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com> Signed-off-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com> Signed-off-by: Matt Farina <matt@mattfarina.com> Signed-off-by: Chris Berry <bez625@gmail.com> Signed-off-by: Chris <bez625@gmail.com> Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> Signed-off-by: Patrick Seidensal <pseidensal@suse.com> Signed-off-by: dongjiang <dongjiang1989@126.com> Co-authored-by: George Jenkins <gvjenkins@gmail.com> Co-authored-by: Andrew Block <andy.block@gmail.com> Co-authored-by: Matt Farina <matt.farina@suse.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Robert Sirchia <rsirchia@outlook.com> Co-authored-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de> Co-authored-by: Josh Dolitsky <393494+jdolitsky@users.noreply.github.com> Co-authored-by: Trent V <trenton.vanderwert@suse.com> Co-authored-by: Bryan Honof <bryan@flox.dev> Co-authored-by: Trent V. <trenton.vanderwert@gmail.com> Co-authored-by: Luis Davim <luis.davim@gmail.com> Co-authored-by: Evans Mungai <mbuevans@gmail.com> Co-authored-by: Jon Olsson <jon.olsson@sequitor.se> Co-authored-by: Andreas Karis <ak.karis@gmail.com> Co-authored-by: wangjingcun <wangjingcun@aliyun.com> Co-authored-by: Tianle Xu <xtl@xtlsoft.top> Co-authored-by: Suleiman Dibirov <idsulik@gmail.com> Co-authored-by: Zach Burgess <zachburg@google.com> Co-authored-by: Alex Johnson <alex.kattathra.johnson@gmail.com> Co-authored-by: Taylor Jasko <taylor@taylorjasko.com> Co-authored-by: Mayank Shah <mayankshah1614@gmail.com> Co-authored-by: Ryan Nowak <nowakra@gmail.com> Co-authored-by: Althaf M <althafm@outlook.com> Co-authored-by: Matt Farina <matt@mattfarina.com> Co-authored-by: Niladri Halder <niladri.halder26@gmail.com> Co-authored-by: dnskr <dnskrv88@gmail.com> Co-authored-by: cx <1249843194@qq.com> Co-authored-by: Terry Howe <terrylhowe@gmail.com> Co-authored-by: Scott Rigby <scott@r6by.com> Co-authored-by: Ryan Hockstad <ryanhockstad@gmail.com> Co-authored-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com> Co-authored-by: Chris Berry <bez625@gmail.com> Co-authored-by: Benoit Tigeot <benoit.tigeot@lifen.fr> Co-authored-by: Patrick Seidensal <pseidensal@suse.com> Co-authored-by: dongjiang <dongjiang1989@126.com>
This was referenced May 12, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
May 20, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [helm/helm](https://github.com/helm/helm) | minor | `v3.17.3` -> `v3.18.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>helm/helm (helm/helm)</summary> ### [`v3.18.0`](https://github.com/helm/helm/releases/tag/v3.18.0): Helm v3.18.0 [Compare Source](helm/helm@v3.17.3...v3.18.0) Helm v3.18.0 is a feature release. Users are encouraged to upgrade for the best experience. The community keeps growing, and we'd love to see you there! - Join the discussion in [Kubernetes Slack](https://kubernetes.slack.com): - for questions and just to hang out - for discussing MRs, code, and bugs - Hang out at the Public Developer Call: Thursday, 9:30 Pacific via [Zoom](https://zoom.us/j/696660622) - Test, debug, and contribute charts: [ArtifactHub/packages](https://artifacthub.io/packages/search?kind=0) #### Notable Changes - Add support for JSON Schema 2020 - Enabled cpu and memory profiling - Add hook annotation to output hook logs to client on error #### Installation and Upgrading Download Helm v3.18.0. The common platform binaries are here: - [MacOS amd64](https://get.helm.sh/helm-v3.18.0-darwin-amd64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.18.0-darwin-amd64.tar.gz.sha256sum) / 2be99836549413c2f0212d644e8740abd8ba5d7f55484c29d3363cea339891d9) - [MacOS arm64](https://get.helm.sh/helm-v3.18.0-darwin-arm64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.18.0-darwin-arm64.tar.gz.sha256sum) / 4ce30bd86a3fc4f31d297827a5bf5b10ced8c4da2ff810bf9f53f561dbed7d10) - [Linux amd64](https://get.helm.sh/helm-v3.18.0-linux-amd64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.18.0-linux-amd64.tar.gz.sha256sum) / 961e587fc2c03807f8a99ac25ef063fa9e6915f1894729399cbb95d2a79af931) - [Linux arm](https://get.helm.sh/helm-v3.18.0-linux-arm.tar.gz) ([checksum](https://get.helm.sh/helm-v3.18.0-linux-arm.tar.gz.sha256sum) / 88f6264801fd9c5bb3d2d24c7b3da4e239d137b39bacd18d25b22823e6bd31f7) - [Linux arm64](https://get.helm.sh/helm-v3.18.0-linux-arm64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.18.0-linux-arm64.tar.gz.sha256sum) / 489c9d2d3ea4e095331249d74b4407fb5ac1d338c28429d70cdedccfe6e2b029) - [Linux i386](https://get.helm.sh/helm-v3.18.0-linux-386.tar.gz) ([checksum](https://get.helm.sh/helm-v3.18.0-linux-386.tar.gz.sha256sum) / 3302c90957e259897d238feee65e05abb3fc586ab80a49cb577fd123b2e94cb3) - [Linux ppc64le](https://get.helm.sh/helm-v3.18.0-linux-ppc64le.tar.gz) ([checksum](https://get.helm.sh/helm-v3.18.0-linux-ppc64le.tar.gz.sha256sum) / 559036fe183593488275a19796ca0b13f56e9d586b697a0d968e8b1e24472d7c) - [Linux s390x](https://get.helm.sh/helm-v3.18.0-linux-s390x.tar.gz) ([checksum](https://get.helm.sh/helm-v3.18.0-linux-s390x.tar.gz.sha256sum) / ab0e347751b425ed9c4b619159a9ffeb85a82e07f7333921dec1a26780195a72) - [Linux riscv64](https://get.helm.sh/helm-v3.18.0-linux-riscv64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.18.0-linux-riscv64.tar.gz.sha256sum) / ae98c3d9d352ac91909d28dbb03d91fc506cafcce647cfbd1954a02ef84f91d1) - [Windows amd64](https://get.helm.sh/helm-v3.18.0-windows-amd64.zip) ([checksum](https://get.helm.sh/helm-v3.18.0-windows-amd64.zip.sha256sum) / ae6a1b832043e3433d2823fc42692057dbf007efad34292708130b412c169a94) - [Windows arm64](https://get.helm.sh/helm-v3.18.0-windows-arm64.zip) ([checksum](https://get.helm.sh/helm-v3.18.0-windows-arm64.zip.sha256sum) / f354f0bdf725a0530162754632bc54fed2c56ad11a899b031702ee1c70ecb5fc) The [Quickstart Guide](https://helm.sh/docs/intro/quickstart/) will get you going from there. For **upgrade instructions** or detailed installation notes, check the [install guide](https://helm.sh/docs/intro/install/). You can also use a [script to install](https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3) on any system with `bash`. #### What's Next - 3.18.1 on June 11th, 2025 will contain only bug fixes. - 3.19.0 on September 11th, 2025 is the next feature release. #### Changelog - build(deps): bump the k8s-io group with 7 updates [`cc58e3f`](helm/helm@cc58e3f) (dependabot\[bot]) - fix: govulncheck workflow [`bf1436b`](helm/helm@bf1436b) (Matthieu MOREL) - bump version to v3.18.0 [`d8edc2a`](helm/helm@d8edc2a) (Robert Sirchia) - fix:add proxy support when mTLS configured [`48377fe`](helm/helm@48377fe) (Rongrong Liu) - docs: Note about http fallback for OCI registries [`cdd7c10`](helm/helm@cdd7c10) (Terry Howe) - Bump net package to avoid CVE on dev-v3 [`f9ab8f7`](helm/helm@f9ab8f7) (Benoit Tigeot) - Bump toml [`087fa18`](helm/helm@087fa18) (Benoit Tigeot) - backport #​30677to dev3 [`2a5f83b`](helm/helm@2a5f83b) (dongjiang) - build(deps): bump github.com/rubenv/sql-migrate from 1.7.2 to 1.8.0 [`5df2f30`](helm/helm@5df2f30) (dependabot\[bot]) - Add install test for TakeOwnership flag [`0906fe7`](helm/helm@0906fe7) (Evans Mungai) - Fix --take-ownership [`4ee3a19`](helm/helm@4ee3a19) (Patrick Seidensal) - build(deps): bump github.com/rubenv/sql-migrate from 1.7.1 to 1.7.2 [`3538c2a`](helm/helm@3538c2a) (dependabot\[bot]) - build(deps): bump golang.org/x/crypto from 0.36.0 to 0.37.0 [`6fa95c8`](helm/helm@6fa95c8) (dependabot\[bot]) - build(deps): bump golang.org/x/term from 0.30.0 to 0.31.0 [`741b5be`](helm/helm@741b5be) (dependabot\[bot]) - Testing text bump [`017f9fa`](helm/helm@017f9fa) (Benoit Tigeot) - Permit more Go version and not only 1.23.8 [`6667252`](helm/helm@6667252) (Benoit Tigeot) - Bumps github.com/distribution/distribution/v3 from 3.0.0-rc.3 to 3.0.0 [`4ad1ccd`](helm/helm@4ad1ccd) (Benoit Tigeot) - Unarchiving fix [`3ce10e4`](helm/helm@3ce10e4) (Matt Farina) - Fix typo [`422c58e`](helm/helm@422c58e) (Benoit Tigeot) - Report as debug log, the time spent waiting for resources [`5e7f12d`](helm/helm@5e7f12d) (Benoit Tigeot) - build(deps): bump github.com/containerd/containerd from 1.7.26 to 1.7.27 [`dcc286c`](helm/helm@dcc286c) (dependabot\[bot]) - Update pkg/registry/fallback.go [`1435ec7`](helm/helm@1435ec7) (Terry Howe) - automatic fallback to http [`674e882`](helm/helm@674e882) (Terry Howe) - chore(oci): upgrade to ORAS v2 [`c188441`](helm/helm@c188441) (Terry Howe) - Updating to 0.37.0 for x/net [`2b12490`](helm/helm@2b12490) (Matt Farina) - build(deps): bump the k8s-io group with 7 updates [`0648918`](helm/helm@0648918) (dependabot\[bot]) - build(deps): bump golang.org/x/crypto from 0.35.0 to 0.36.0 [`0911b9c`](helm/helm@0911b9c) (dependabot\[bot]) - build(deps): bump github.com/opencontainers/image-spec [`2f22d55`](helm/helm@2f22d55) (dependabot\[bot]) - build(deps): bump github.com/containerd/containerd from 1.7.25 to 1.7.26 [`89361c9`](helm/helm@89361c9) (dependabot\[bot]) - build(deps): bump golang.org/x/crypto from 0.33.0 to 0.35.0 [`6d64160`](helm/helm@6d64160) (dependabot\[bot]) - Fix cherry-pick helm.sh/helm/v4 -> helm.sh/helm/v3 [`bcb83e4`](helm/helm@bcb83e4) (Scott Rigby) - Refactor based on review comment [`2aa90b8`](helm/helm@2aa90b8) (Chris Berry) - Refactor based on review comment [`5739197`](helm/helm@5739197) (Chris Berry) - Add HookOutputFunc and generic yaml unmarshaller [`b8e1387`](helm/helm@b8e1387) (Chris Berry) - clarify fix error message [`97b0e11`](helm/helm@97b0e11) (Scott Rigby) - fix err check [`2f79afb`](helm/helm@2f79afb) (Scott Rigby) - remove comments about previous functionality [`c77f4ec`](helm/helm@c77f4ec) (Scott Rigby) - add short circuit return [`3cd6afe`](helm/helm@3cd6afe) (Scott Rigby) - Update based on review comments [`5367001`](helm/helm@5367001) (Chris Berry) - Update based on review comments [`3c44515`](helm/helm@3c44515) (Chris Berry) - Fix lint [`4cb639e`](helm/helm@4cb639e) (Chris Berry) - Tidy up imports [`20f859c`](helm/helm@20f859c) (Chris) - Add hook annotations to output pod logs to client on success and fail [`ca90972`](helm/helm@ca90972) (Chris Berry) - chore: use \[]error instead of \[]string [`a9e2075`](helm/helm@a9e2075) (Evans Mungai) - Update cmd/helm/profiling.go [`996ad84`](helm/helm@996ad84) (Evans Mungai) - chore: update profiling doc in CONTRIBUTING.md [`867c97e`](helm/helm@867c97e) (Evans Mungai) - Update CONTRIBUTING guide [`af24101`](helm/helm@af24101) (Evans Mungai) - Prefer environment variables to CLI flags [`c7dfa87`](helm/helm@c7dfa87) (Evans Mungai) - Fix linter warning [`b39411a`](helm/helm@b39411a) (Evans Mungai) - Move pprof paths to HELM_PPROF env variable [`4c50f01`](helm/helm@4c50f01) (Evans Mungai) - Update CONTRIBUTING.md [`3b43f7b`](helm/helm@3b43f7b) (Evans Mungai) - Update CONTRIBUTING.md [`a32e11b`](helm/helm@a32e11b) (Evans Mungai) - Additional review fixes from MR [`483ebf9`](helm/helm@483ebf9) (Evans Mungai) - feat: Add flags to enable CPU and memory profiling [`461197f`](helm/helm@461197f) (Evans Mungai) - build(deps): bump github.com/distribution/distribution/v3 [`e7fa545`](helm/helm@e7fa545) (dependabot\[bot]) - build(deps): bump github.com/spf13/cobra from 1.8.1 to 1.9.1 [`d1687ba`](helm/helm@d1687ba) (dependabot\[bot]) - Moving to SetOut and SetErr for Cobra [`4c2f88b`](helm/helm@4c2f88b) (Matt Farina) - build(deps): bump the k8s-io group with 7 updates [`a2413aa`](helm/helm@a2413aa) (dependabot\[bot]) - build(deps): bump golang.org/x/crypto from 0.32.0 to 0.33.0 [`959d643`](helm/helm@959d643) (dependabot\[bot]) - build(deps): bump golang.org/x/term from 0.28.0 to 0.29.0 [`3a87c68`](helm/helm@3a87c68) (dependabot\[bot]) - build(deps): bump golang.org/x/text from 0.21.0 to 0.22.0 [`711cef8`](helm/helm@711cef8) (dependabot\[bot]) - build(deps): bump github.com/spf13/pflag from 1.0.5 to 1.0.6 [`7680623`](helm/helm@7680623) (dependabot\[bot]) - build(deps): bump github.com/cyphar/filepath-securejoin [`03747d9`](helm/helm@03747d9) (dependabot\[bot]) - build(deps): bump github.com/evanphx/json-patch [`f1db83f`](helm/helm@f1db83f) (dependabot\[bot]) - build(deps): bump the k8s-io group with 7 updates [`3bc3751`](helm/helm@3bc3751) (dependabot\[bot]) - fix: check group for resource info match [`2ebce78`](helm/helm@2ebce78) (Jiasheng Zhu) - Bump github.com/cyphar/filepath-securejoin from 0.3.6 to 0.4.0 [`8e86e76`](helm/helm@8e86e76) (dependabot\[bot]) - add test for nullifying nested global value [`326c1e3`](helm/helm@326c1e3) (Ryan Hockstad) - Ensuring the file paths are clean prior to passing to securejoin [`fba9d08`](helm/helm@fba9d08) (Matt Farina) - Bump github.com/containerd/containerd from 1.7.24 to 1.7.25 [`a79be7d`](helm/helm@a79be7d) (dependabot\[bot]) - Bump golang.org/x/crypto from 0.31.0 to 0.32.0 [`b029d74`](helm/helm@b029d74) (dependabot\[bot]) - Bump golang.org/x/term from 0.27.0 to 0.28.0 [`a1c0ae8`](helm/helm@a1c0ae8) (dependabot\[bot]) - bump version to v3.17.0 [`d6db69e`](helm/helm@d6db69e) (Matt Farina) - Bump github.com/moby/term from 0.5.0 to 0.5.2 [`54ffefb`](helm/helm@54ffefb) (dependabot\[bot]) - Add test case for removing an entire object [`ef2eb55`](helm/helm@ef2eb55) (Ryan Hockstad) - Tests for bugfix: Override subcharts with null values [#​12879](helm/helm#12879) [`60fcce1`](helm/helm@60fcce1) (Scott Rigby) - feat: Added multi-platform plugin hook support to v3 Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com> [`83dddb1`](helm/helm@83dddb1) (Andrew Block) - This commit fixes the issue where the yaml.Unmarshaller converts all int values into float64, this passes in option to decoder, which enables conversion of int into . [`0a6834f`](helm/helm@0a6834f) (Althaf M) - merge null child chart objects [`5a58751`](helm/helm@5a58751) (Ryan Hockstad) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xNS4wIiwidXBkYXRlZEluVmVyIjoiNDAuMTUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
swastik959
pushed a commit
to swastik959/helm
that referenced
this pull request
Aug 22, 2025
- Add consistency for null test in given values, parent chart, subchart, and sub-sub-chart - Remove bar null test to keep consistent with boat=null at top level Signed-off-by: Scott Rigby <scott@r6by.com> (cherry picked from commit 60fcce1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #12469 and closes #12488
Helm should allow users to not only override default values, but also completely remove any default values by setting a config to
null.This works fine for regular charts, but default values within sub-charts cannot be
null-ed. The linked issue has a good example of this created by user "naemono."The reason this issue is happening is because the
coalescefunction goes over sub-chart values that are defined in a values file or with a--setflag twice due to the logic here.mergeis always set tofalsein this context, and the first timecoalescegets called, the null value gets removed during thecoalesceTablesFullKeyfunction here. This is fine for regular chart values, but for sub-chart values, thecoalesceDepsfunction runs the logic again for every value in the subChart, so we end right back to the spot in the previous link. But the config option that was explicitly set to null was already removed, so we end up at this point two lines down, which overwrites the user definednullconfig the sub-chart default value.This problem only occurs because when the
coalescefunction is run whilemergeisfalse.To prevent this bug from removing sub-chart config values that are explicitly set to
nulland therefore getting overwritten whencoalesceDepsruns through the sub-chart values a second time, I added logic to check if the key was the name of a sub-chart, and if so settingmergetofalseso the null config option is not deleted.Special notes for your reviewer:
Follow-up if this PR is accepted may be to add a unit-test to confirm sub-chart nulls aren't overwritten.