Feature / toml parsing #12026
Merged
Feature / toml parsing #12026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to use `fromToml` in templates similar to `fromJson` or `fromYaml`. Closes helm#12024 Signed-off-by: Dominik Müller <mail@dominikm.de>
Signed-off-by: Dominik Müller <mail@dominikm.de>
582f13d to
266ab5a
Compare
|
nice! exactly what I am waiting for! Please merge 🙏 |
dominikmueller
added a commit
to dominikmueller/helm-www
that referenced
this pull request
Apr 25, 2023
Explains how `toToml` and `fromToml` can be used in chart templates. Implementation detail can be seen here: helm/helm#12026. Signed-off-by: Dominik Müller <mail@dominikm.de>
dominikmueller
added a commit
to dominikmueller/helm-www
that referenced
this pull request
Apr 25, 2023
Explains how `toToml` and `fromToml` can be used in chart templates. Implementation detail can be seen here: helm/helm#12026. Signed-off-by: Dominik Müller <mail@dominikm.de>
dominikmueller
added a commit
to dominikmueller/helm-www
that referenced
this pull request
Apr 25, 2023
Explains how `toToml` and `fromToml` can be used in chart templates. Implementation detail can be seen here: helm/helm#12026. Signed-off-by: Dominik Müller <mail@dominikm.de>
dominikmueller
added a commit
to dominikmueller/helm-www
that referenced
this pull request
Apr 25, 2023
Explains how `toToml` and `fromToml` can be used in chart templates. Implementation detail can be seen here: helm/helm#12026. Signed-off-by: Dominik Müller <mail@dominikm.de>
gjenkins8
approved these changes
Aug 18, 2024
|
Please correct the DCO issue. |
mattfarina
approved these changes
Aug 22, 2024
|
The DCO issue is because the bot that does the check didn't respond. It appears the correct sign-off is on the commit. @dominikmueller could you rebase this from main? That should fix the DCO issue and cause the test suite to run properly in CI. Otherwise, this looks ready to merge. |
Signed-off-by: Joe Julian <me@joejulian.name>
|
I merged in main to fix the DCO issue and start CI running. |
joejulian
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
fromTomlfunction that allows parsing TOML configuration. LikefromJsonorfromYaml.Closes #12024.
Special notes for your reviewer:
I added docs for
toToml(have been missing) andfromToml(new implementation) to the helm-www repo in this PR: helm/helm-www#1455If applicable:
-> Documentation can be found here: Add docs for TOML functions helm-www#1455
-> It's a new feature and should therefore not cause any compatibility issues.