Remove "top" from linear-gradient - it's the wrong syntax #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mlettini Does this have any browser-support issues? I.e. was the old syntax better supported in older browsers? Or does everything that supports the old also support the new? |
|
@tjschuck This should not have any browser-support issues. Also there's 4 places where we're currently using |
mlettini
pushed a commit
that referenced
this pull request
Jul 13, 2015
Remove "top" from linear-gradient - it's the wrong syntax
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tjschuck @pfiller @koenpunt @altras
Fixes #2363
Our linear gradients go from top-to-bottom, and according to the latest syntax we should be using
to bottom, but since that's the default we don't need to specify that. Having no direction will goto bottomanyway.