add support for paste events #1603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -222,6 +222,12 @@ class AbstractChosen | |||
| # don't do anything on these keys | |||
| else this.results_search() | |||
|
|
|||
| paste_checker: (evt) -> | |||
| chosen = this | |||
| callback = -> | |||
There was a problem hiding this comment.
use => and you will not need chosen = this anymore
|
@daveworth Can you squash this down to one logical commit? Instructions. Thanks! |
|
Done. Thanks! |
| callback = => | ||
| this.results_search() | ||
| setTimeout(callback, 50) | ||
|
|
There was a problem hiding this comment.
There is no need for the extra callback var:
setTimeout (=> this.results_search()), 50|
I think the same kind of callback should be triggered when cutting text from the input. |
|
@koenpunt Thanks for the feedback. The local-variable is now kaput. |
A short delay (currently 50ms) is required after the paste event for the pasted text to enter the textbox. Then we can trigger a `keyup` event as if that copy had just been typed into the box manually.
|
@koenpunt - and cut events are handled now. Thanks for the feedback and the cut event was a great call. It didn't scratch my itch as paste did so I was blind to it. 😄 |
|
Cool, thanks! |
|
@pfiller ping! |
|
Thanks @daveworth - I am going to go paste some stuff right now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short delay (currently 50ms) is required after the paste event for the
pasted text to enter the textbox. Then we can trigger a
keyupevent as ifthat copy had just been typed into the box manually.
This is meant to address #1601 opened by me today.