Single select results in sync #1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When choosing an option in a single select, we need to update the array of options to deselect any previously selected options.
|
Looks good. Tested both jQuery and Prototype in Chrome, FF, and IEs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@harvesthq/chosen-developers
This fixes some issues in single selects that come when the data and DOM get out of sync. The trouble comes from relying on the
results-selectedclass for tracking selected results. Since our results list now gets rebuilt with every winnow,results-selecteddoesn't always reflect an item that actually exists (or sometimes reflects old selections).Two issues I saw
results-selectedclass (No placeholder results in odd behaviour #1458)xin the example and re-open the list. "Sloth bear" is still highlighted.This PR fixes both of those. I still need to do some performance testing in IE8 with thousands of options, but I don't think this is going to be a problem. Looping through an array of thousands of items in IE8 is surprisingly quick.
Fixes #1458
Fixes #1391 (again)