Use document.createElement instead of html string #1430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…koenpunt-dom-create-element
permanent home with other dom utilities.
|
Looks good. |
pfiller
added a commit
that referenced
this pull request
Jul 30, 2013
Use document.createElement instead of html string
|
Thanks @koenpunt!! |
|
I still think that |
|
I agree with you that outerHTML(some_el);
this.outerHTML(some_el);
ChosenUtils.outerHTML(some_el);The first option looks like a native JS method. When it comes time to debug it's output, that could add a little bit of unnecessary confusion. The second two tell you exactly where they came from and tracking down the source of the function is a no brainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@harvesthq/chosen-developers
This is a slight modification of #1414 from @koenpunt. It just takes the
outerHTMLmethod he created and moves it into the AbstractChosen method. At some point, we should create a class of dom utilities, but this is an ok home for now.Fixes #336