VAULT-36229: Nonce for rekey cancellations #30794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Results: |
|
Build Results: |
53e162c to
1f6afd7
Compare
schavis
previously approved these changes
Jun 4, 2025
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
schavis
previously approved these changes
Jun 4, 2025
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
jonathanfrappier
approved these changes
Jun 5, 2025
stevendpclark
approved these changes
Jun 5, 2025
6 tasks
miagilepner
added a commit
that referenced
this pull request
Jun 6, 2025
* require nonce for rekey * update doc * add changelog * Apply suggestions from code review Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
This was referenced Jun 6, 2025
Merged
Merged
miagilepner
added a commit
that referenced
this pull request
Jun 9, 2025
….19.x (#30862) * VAULT-36229: Nonce for rekey cancellations (#30794) * require nonce for rekey * update doc * add changelog * Apply suggestions from code review Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * fix header --------- Co-authored-by: miagilepner <mia.epner@hashicorp.com> Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
drivera258
pushed a commit
that referenced
this pull request
Jun 11, 2025
* require nonce for rekey * update doc * add changelog * Apply suggestions from code review Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a nonce for rekey cancellations
Enterprise PR: https://github.com/hashicorp/vault-enterprise/pull/8169
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.