Skip to content

Conversation

hellobontempo
Copy link
Contributor

Description

The introduction of the Vault Usage dashboard introduced a naming conflict with the client count nav link Vault Usage Metrics. Renaming it to Client Usage to more accurately align with the content.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo added this to the 1.20.0-rc milestone May 27, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 27, 2025
@hellobontempo hellobontempo marked this pull request as ready for review May 27, 2025 20:36
@hellobontempo hellobontempo requested review from a team as code owners May 27, 2025 20:36
@hellobontempo hellobontempo requested review from sapleu-hc and removed request for sapleu-hc May 27, 2025 20:36
Copy link

github-actions bot commented May 27, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@hellobontempo hellobontempo enabled auto-merge (squash) May 27, 2025 20:58
@hellobontempo hellobontempo disabled auto-merge May 27, 2025 20:59
@hellobontempo
Copy link
Contributor Author

Screenshot 2025-05-27 at 2 18 00 PM

@hellobontempo hellobontempo merged commit 8d0bdac into main May 27, 2025
39 of 40 checks passed
@hellobontempo hellobontempo deleted the ui/update-client-count-nav-link branch May 27, 2025 21:18
drivera258 pushed a commit that referenced this pull request Jun 4, 2025
* rename references to "Vault Usage Metrics" to "Client Usage"

* add changelog
drivera258 pushed a commit that referenced this pull request Jun 11, 2025
* rename references to "Vault Usage Metrics" to "Client Usage"

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants