refactor changes for irrevocable lease removal #30703
Merged
+79
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Results: |
|
Build Results: |
973abe2 to
7626113
Compare
7626113 to
321c361
Compare
digivava
reviewed
May 21, 2025
digivava
reviewed
May 22, 2025
digivava
reviewed
May 22, 2025
digivava
approved these changes
May 22, 2025
miagilepner
pushed a commit
that referenced
this pull request
May 23, 2025
* refactor changes for irrevocable lease removal * changelog addition * add logs * update changelog; always sleep during irrevocable lease revoke party * comment * typo * pass Core pntr to removeIrrevocableLeasesEnabled * remove log
erentantekin
pushed a commit
that referenced
this pull request
May 23, 2025
* refactor changes for irrevocable lease removal * changelog addition * add logs * update changelog; always sleep during irrevocable lease revoke party * comment * typo * pass Core pntr to removeIrrevocableLeasesEnabled * remove log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
irrevocableLeaseRemovalfeature at Vault startupdeleteLeaseCommonfunctionirrevocableLeaseRemovalis enabled, a force revoke is performed instead of a deferred delete