-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[VAULT-35162] Development Cluster setting docs #30659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI Results: |
Build Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please make sure to get approval from someone in the vault-docs team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor style edits.
Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
e5f3901
to
35b5210
Compare
* add docs * change wording * add changelog * Update changelog/30659.txt Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com> * Apply suggestions from code review Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> --------- Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com> Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
indicates whether the cluster is used for development (non-production) purposes. By default, the field is set to `false`, | ||
indicating the cluster is running in a production environment. Changing the value is done via HCL configuration by adding | ||
the `development_cluster` field to the `license` parameter within the `reporting` stanza. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be helpful to indicate that this should only be done if the cluster is not a production cluster -- there are EULA implications if this is applied to a prod cluster
reported `development_cluster` value when the primary cluster changes. | ||
|
||
Within each cluster, each node must have the same `development_cluster` setting in its configuration to be consistent. | ||
In the event of leadership change, nodes will use its server configuration to determine the value to report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"In the event of a leadership change, each node will use its own server configuration to determine the value to report."
|
||
Within each cluster, each node must have the same `development_cluster` setting in its configuration to be consistent. | ||
In the event of leadership change, nodes will use its server configuration to determine the value to report. | ||
Inconsistent configuration between nodes will change the `development_cluster` setting reported upon active unseal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you be more specific with an example?
@@ -240,6 +280,7 @@ HashiCorp collects the following utilization data as JSON payloads: | |||
|
|||
- `cluster_id` - The cluster UUID as shown by `vault status` on the reporting | |||
cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put a period at the end for consistency
Description
This PR adds the documentation for the new
development_cluster
config value and Census report metadata field. It also includes the changelog for the feature.Jira: https://hashicorp.atlassian.net/browse/VAULT-35162
RFC: https://go.hashi.co/rfc/vlt-348
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.