Skip to content

Conversation

blueberry-pi
Copy link
Contributor

Description

This PR adds the documentation for the new development_cluster config value and Census report metadata field. It also includes the changelog for the feature.

Jira: https://hashicorp.atlassian.net/browse/VAULT-35162
RFC: https://go.hashi.co/rfc/vlt-348

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@blueberry-pi blueberry-pi added this to the 1.20.0-rc milestone May 16, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 16, 2025
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@blueberry-pi blueberry-pi requested a review from schavis May 16, 2025 20:31
divyaac
divyaac previously approved these changes May 16, 2025
Copy link
Contributor

@divyaac divyaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please make sure to get approval from someone in the vault-docs team

Copy link
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor style edits.

blueberry-pi and others added 5 commits May 19, 2025 11:46
Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
@blueberry-pi blueberry-pi requested a review from divyaac May 19, 2025 19:18
@blueberry-pi blueberry-pi merged commit 1b037c9 into main May 19, 2025
34 checks passed
@blueberry-pi blueberry-pi deleted the vault-35162-development-cluster-docs branch May 19, 2025 19:26
erentantekin pushed a commit that referenced this pull request May 23, 2025
* add docs

* change wording

* add changelog

* Update changelog/30659.txt

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>

* Apply suggestions from code review

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

---------

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
indicates whether the cluster is used for development (non-production) purposes. By default, the field is set to `false`,
indicating the cluster is running in a production environment. Changing the value is done via HCL configuration by adding
the `development_cluster` field to the `license` parameter within the `reporting` stanza.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be helpful to indicate that this should only be done if the cluster is not a production cluster -- there are EULA implications if this is applied to a prod cluster

reported `development_cluster` value when the primary cluster changes.

Within each cluster, each node must have the same `development_cluster` setting in its configuration to be consistent.
In the event of leadership change, nodes will use its server configuration to determine the value to report.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"In the event of a leadership change, each node will use its own server configuration to determine the value to report."


Within each cluster, each node must have the same `development_cluster` setting in its configuration to be consistent.
In the event of leadership change, nodes will use its server configuration to determine the value to report.
Inconsistent configuration between nodes will change the `development_cluster` setting reported upon active unseal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more specific with an example?

@@ -240,6 +280,7 @@ HashiCorp collects the following utilization data as JSON payloads:

- `cluster_id` - The cluster UUID as shown by `vault status` on the reporting
cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put a period at the end for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants