PR: Set autocomplete="off" for new auth fields
#30444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Results: |
|
Build Results: |
hellobontempo
commented
Apr 29, 2025
| @@ -20,15 +18,4 @@ interface Field { | |||
| export default class AuthFields extends Component<Args> { | |||
| // token or password should render as "password" types, otherwise render text inputs | |||
| setInputType = (field: string) => (['token', 'password'].includes(field) ? 'password' : 'text'); | |||
There was a problem hiding this comment.
This is small enough it could happen in the component, but I thought the interfaces might be helpful in the future:
vault/ui/app/components/auth/fields.ts
Lines 8 to 16 in e95f145
If they seem unnecessary, happy to remove the backing class!
lane-wetmore
approved these changes
Apr 29, 2025
drivera258
pushed a commit
that referenced
this pull request
Apr 30, 2025
* set autocomplete to off * add comment * update test
6 tasks
Erfankam
pushed a commit
to Erfankam/vault
that referenced
this pull request
Sep 1, 2025
* set autocomplete to off * add comment * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After consulting with security folks, we decided to hold off on implementing "autocomplete" functionality in the login form for now. There's concern this will upset the security expectations of some users.
We can revisit this if a strong case comes up to support autocomplete. If we end up making this change, we will likely only support autocomplete for non-token fields.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.