[VAULT-34483] UI: implement front-end pagination via infinite scroll #30433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Results: |
|
Build Results: |
f53662c to
da316fa
Compare
…amespace picker in sidebar footer
…arch input is cleared
49006cd to
a9cc95b
Compare
Monkeychip
reviewed
Apr 29, 2025
| @@ -3,49 +3,61 @@ | |||
| SPDX-License-Identifier: BUSL-1.1 | |||
| }} | |||
|
|
|||
| <div class="namespace-picker" ...attributes> | |||
| <div class="top-padding-4 has-bottom-padding-4 has-side-padding-8" ...attributes> | |||
Monkeychip
reviewed
Apr 29, 2025
| @@ -77,7 +77,6 @@ | |||
| @use 'components/loader'; | |||
| @use 'components/login-form'; | |||
| @use 'components/masked-input'; | |||
| @use 'components/namespace-picker'; | |||
7c57f56
into
VAULT-34216/namespace-picker-feature-branch
25 checks passed
beagins
added a commit
that referenced
this pull request
Apr 29, 2025
…30433) * [VAULT-34483] UI: implement front-end pagination via infinite scroll * remove unnecessary height definition * fix test: Integration | Component | sidebar-frame: it should render namespace picker in sidebar footer * update comment * move visibleNamespaceOptions into a getter so that it updates when search input is cleared * handle edge case: display current namespace when no other namespaces listed
beagins
added a commit
that referenced
this pull request
Apr 29, 2025
…30433) * [VAULT-34483] UI: implement front-end pagination via infinite scroll * remove unnecessary height definition * fix test: Integration | Component | sidebar-frame: it should render namespace picker in sidebar footer * update comment * move visibleNamespaceOptions into a getter so that it updates when search input is cleared * handle edge case: display current namespace when no other namespaces listed
beagins
added a commit
that referenced
this pull request
Apr 30, 2025
…30433) * [VAULT-34483] UI: implement front-end pagination via infinite scroll * remove unnecessary height definition * fix test: Integration | Component | sidebar-frame: it should render namespace picker in sidebar footer * update comment * move visibleNamespaceOptions into a getter so that it updates when search input is cleared * handle edge case: display current namespace when no other namespaces listed
beagins
added a commit
that referenced
this pull request
May 1, 2025
…30433) * [VAULT-34483] UI: implement front-end pagination via infinite scroll * remove unnecessary height definition * fix test: Integration | Component | sidebar-frame: it should render namespace picker in sidebar footer * update comment * move visibleNamespaceOptions into a getter so that it updates when search input is cleared * handle edge case: display current namespace when no other namespaces listed
beagins
added a commit
that referenced
this pull request
May 1, 2025
…30433) * [VAULT-34483] UI: implement front-end pagination via infinite scroll * remove unnecessary height definition * fix test: Integration | Component | sidebar-frame: it should render namespace picker in sidebar footer * update comment * move visibleNamespaceOptions into a getter so that it updates when search input is cleared * handle edge case: display current namespace when no other namespaces listed
beagins
added a commit
that referenced
this pull request
May 5, 2025
…30433) * [VAULT-34483] UI: implement front-end pagination via infinite scroll * remove unnecessary height definition * fix test: Integration | Component | sidebar-frame: it should render namespace picker in sidebar footer * update comment * move visibleNamespaceOptions into a getter so that it updates when search input is cleared * handle edge case: display current namespace when no other namespaces listed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainDescription
Demos
Before: Loading 10K namespaces
Screen.Recording.2025-04-28.at.4.14.10.PM.mov
After: Loading 10K namespaces with front-end infinite scroll (loading 200 at a time)
Screen.Recording.2025-04-28.at.4.11.54.PM.mov
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.