Add snowflake DB API warning #30327
Merged
Add snowflake DB API warning #30327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Results: |
|
CI Results: |
fairclothjm
reviewed
Apr 23, 2025
website/content/partials/deprecation/snowflake-password-auth.mdx
Outdated
Show resolved
Hide resolved
fairclothjm
previously approved these changes
Apr 23, 2025
There was a problem hiding this comment.
LGTM, but had a few more thoughts:
Should we also add a notice at the top of the Snowflake overview page here https://vault-oj7azsli6-hashicorp.vercel.app/vault/docs/secrets/databases/snowflake and on the API page here https://vault-oj7azsli6-hashicorp.vercel.app/vault/api-docs/secret/databases/snowflake?
Also, maybe we should mark the Capabilities table entries for password as deprecated?
fairclothjm
previously approved these changes
Apr 23, 2025
fairclothjm
previously approved these changes
Apr 23, 2025
fairclothjm
reviewed
Apr 23, 2025
fairclothjm
approved these changes
Apr 23, 2025
yhyakuna
approved these changes
Apr 28, 2025
6 tasks
robmonte
added a commit
that referenced
this pull request
Apr 28, 2025
* Add API warning based on DB type * Add deprecation notice * Add warning to the top of the docs pages * Update capabilities table * Filter SQLConnectionProducer fields from unrecognized parameters warning * Add test case
6 tasks
robmonte
added a commit
that referenced
this pull request
Apr 28, 2025
* Add API warning based on DB type * Add deprecation notice * Add warning to the top of the docs pages * Update capabilities table * Filter SQLConnectionProducer fields from unrecognized parameters warning * Add test case
This was referenced Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds warnings for newly created or updated snowflake DB secrets configs for the removal of password authentication.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.