-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[VAULT-35183] UI: enable search for updated namespace picker #30292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VAULT-35183] UI: enable search for updated namespace picker #30292
Conversation
CI Results: |
Build Results: |
...(namespace?.accessibleNamespaces || []).map((ns) => { | ||
const parts = ns.split('/'); | ||
return { id: parts[parts.length - 1], path: ns, label: ns }; | ||
}), | ||
]; | ||
|
||
// Conditionally add the root namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious how this works in reality, is ''/root
still returned from the LIST endpoint on HVD managed clusters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dig in too deep, I just stole this from the previous implementation, but I'll dig in a little to see what's going on & report back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The auth service returns the following as authData
{
"userRootNamespace":"",
"displayName":"token",
"backend":{
"mountPath":"token",
"type":"token",
"typeDisplay":"Token",
"description":"Token authentication.",
"tokenPath":"id",
"displayNamePath":"display_name",
"formAttributes":["token"]
},
"token":"root",
"policies":["root"],
"renewable":false,
"entity_id":"",
"tokenExpirationEpoch":null
}
I'm guessing - and would like to figure out how to confirm this - that userRootNamespace
would be "admin"
for a HVD user
I tried creating a user, bob, w/o access to root
namespace to see the value of userRootNamespace
when bob logs in, but it looks like bob still has access to root
, which is consistent with when I log in as bob on http://localhost:8200/
so it's likely that I'm configuring the policy incorrectly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this can definitely wait until smoke testing at the end, I meant to call that out in my comment. Just sent you a slack about stubbing HVD 😄
882c861
to
4870a1a
Compare
a0687c6
to
a145428
Compare
4870a1a
to
4e2897e
Compare
a145428
to
1661810
Compare
7f2606c
into
VAULT-34216/namespace-picker-feature-branch
Description
main
)root
in list of namespacesDemo
Screen.Recording.2025-04-17.at.7.18.51.PM.mov
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.