Skip to content

Conversation

rculpepper
Copy link
Contributor

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@rculpepper rculpepper requested a review from a team as a code owner April 8, 2025 17:35
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 8, 2025
Copy link

github-actions bot commented Apr 8, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Apr 8, 2025

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should this have a changelog associated with it?

@rculpepper rculpepper requested a review from a team as a code owner April 8, 2025 18:24
@rculpepper rculpepper requested a review from armon April 8, 2025 18:24
@rculpepper rculpepper enabled auto-merge (squash) April 8, 2025 18:33
Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rculpepper rculpepper merged commit 6a3aef7 into main Apr 10, 2025
87 checks passed
@rculpepper rculpepper deleted the rculpepper/transit-managed-keys-rotate-panic branch April 10, 2025 14:34
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants