-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[VAULT-35044] UI: implement action buttons in updated namespace picker #30140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
beagins
merged 4 commits into
VAULT-34216/namespace-picker-feature-branch
from
VAULT-34216/action-buttons
Apr 1, 2025
Merged
[VAULT-35044] UI: implement action buttons in updated namespace picker #30140
beagins
merged 4 commits into
VAULT-34216/namespace-picker-feature-branch
from
VAULT-34216/action-buttons
Apr 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Results: |
Build Results: |
lane-wetmore
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments/questions, but these could be addressed in the next PR if you like.
2dc451f
into
VAULT-34216/namespace-picker-feature-branch
25 checks passed
beagins
added a commit
that referenced
this pull request
Apr 1, 2025
beagins
added a commit
that referenced
this pull request
Apr 3, 2025
beagins
added a commit
that referenced
this pull request
Apr 15, 2025
beagins
added a commit
that referenced
this pull request
Apr 15, 2025
beagins
added a commit
that referenced
this pull request
Apr 18, 2025
beagins
added a commit
that referenced
this pull request
Apr 19, 2025
beagins
added a commit
that referenced
this pull request
Apr 22, 2025
beagins
added a commit
that referenced
this pull request
Apr 24, 2025
beagins
added a commit
that referenced
this pull request
Apr 29, 2025
beagins
added a commit
that referenced
this pull request
Apr 29, 2025
beagins
added a commit
that referenced
this pull request
Apr 29, 2025
beagins
added a commit
that referenced
this pull request
Apr 30, 2025
beagins
added a commit
that referenced
this pull request
May 1, 2025
beagins
added a commit
that referenced
this pull request
May 1, 2025
beagins
added a commit
that referenced
this pull request
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
main
)Outstanding items that will be addressed in separate PRs before the feature side branch is merged to main:
Screenshots
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.