VAULT-32804: Add STS Fallback parameters to secrets-aws engine #29051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cascading fallbacks
This reverts commit 6124b6c.
|
CI Results: |
|
Build Results: |
fairclothjm
reviewed
Dec 3, 2024
robmonte
reviewed
Dec 3, 2024
Co-authored-by: Robert <17119716+robmonte@users.noreply.github.com>
robmonte
previously approved these changes
Dec 4, 2024
fairclothjm
previously approved these changes
Dec 4, 2024
builtin/logical/aws/client.go
Outdated
| return nil, fmt.Errorf("error reading root configuration: %w", err) | ||
| var configs []*aws.Config | ||
|
|
||
| // I'm not sure this is a valid scenario, but the previous code had it as a case. |
There was a problem hiding this comment.
I believe this is possible since none of the aws/config/root fields are required by the API as they can be either set to defaults or the environment. i.e., I don't believe it is required to explicitly call aws/config/root and in that case entry will be nil.
There was a problem hiding this comment.
I've updated the comment to reflect this
fairclothjm
previously approved these changes
Dec 5, 2024
schavis
previously approved these changes
Dec 5, 2024
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
robmonte
approved these changes
Dec 5, 2024
schavis
approved these changes
Dec 5, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Dec 18, 2024
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> --------- Co-authored-by: Robert <17119716+robmonte@users.noreply.github.com> Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two fields,
sts_fallback_endpointsandsts_fallback_regionsto allow credential requests to try other sts regions if the first one fails.To test this one, set up a
secrets/awsmount in the usual way:Now, 'break' us-west-1 somehow, (I suggest messing with
/etc/hosts), and you should get a failure:Experiment with breaking and unbreaking the route to AWS servers - the credential should succeed as long as one sts domain works.
TODO only if you're a HashiCorp employee
in the PR description, commit message, or branch name.