Pin RabbitMQ and Cassandra docker image versions #12174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se v3.8 docker image in tests.
tomhjp
approved these changes
Jul 27, 2021
ncabatoff
added a commit
that referenced
this pull request
Jul 29, 2021
* Work around rabbitmq regression with UserInfo.Tags in rabbitmq 3.9: use v3.8 docker image in tests. * Also pin cassandra docker image version to 3.11 (4.00 was making tests fail)
ncabatoff
added a commit
that referenced
this pull request
Jul 29, 2021
* Work around rabbitmq regression with UserInfo.Tags in rabbitmq 3.9: use v3.8 docker image in tests. * Also pin cassandra docker image version to 3.11 (4.00 was making tests fail)
ncabatoff
added a commit
that referenced
this pull request
Jul 30, 2021
ncabatoff
added a commit
that referenced
this pull request
Jul 30, 2021
swayne275
pushed a commit
that referenced
this pull request
Aug 23, 2021
* Work around rabbitmq regression with UserInfo.Tags in rabbitmq 3.9: use v3.8 docker image in tests. * Also pin cassandra docker image version to 3.11 (4.00 was making tests fail)
swayne275
added a commit
that referenced
this pull request
Aug 23, 2021
* Work around rabbitmq regression with UserInfo.Tags in rabbitmq 3.9: use v3.8 docker image in tests. * Also pin cassandra docker image version to 3.11 (4.00 was making tests fail) Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around a rabbitmq regression in v3.9 with UserInfo.Tags; looks like they're now returning a string array into of a string?
This should fix these test failures:
https://app.circleci.com/pipelines/github/hashicorp/vault/19403/workflows/6758dc1c-b540-44f3-b4d5-0dae53366f32/jobs/251152/tests#failed-test-3
With the above changes I was seeing unrelated failures in Cassandra: looks like they came out with a 4.0.0 docker image just 7 hours ago.
Failures: https://app.circleci.com/pipelines/github/hashicorp/vault/19404/workflows/206773e4-f72f-44fa-86dc-ac88ff6329bf/jobs/251201
So now I'm pinning Cassandra to 3.11 in this PR, in addition to pinning RabbitMQ 3.8.
Presumably we'll still need to make changes to Vault to support newer RabbitMQ/Cassandra versions.