Replace FetchContent with a custom dependency provider #8378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
approved these changes
Aug 8, 2024
|
Spurious failure in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first big change from #8360
The build no longer uses
FetchContent, instead usingfind_packagealways and everywhere. When Halide is the top-level project, it will (by default) inject a dependency provider that overrides thewabt,flatbuffers, andpybind11packages withFetchContent. Users can opt-out by settingHalide_USE_FETCHCONTENT=NO.This also bumps the required
wabtversion to the latest release (1.0.36). This version includes a patch I submitted that fixes the CMake package whenwabtis built with OpenSSL rather than picosha2.Here are relevant links to the docs: