Add Callable default ctor + defined() method
#7380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows it to behave like
abadams
reviewed
Feb 27, 2023
src/Callable.cpp
Outdated
| @@ -197,6 +203,8 @@ Callable::FailureFn Callable::check_fcci(size_t argc, const FullCallCheckInfo *a | |||
| } | |||
|
|
|||
| int Callable::call_argv_checked(size_t argc, const void *const *argv, const QuickCallCheckInfo *actual_qcci) const { | |||
| internal_assert(defined()); | |||
There was a problem hiding this comment.
I think this should be a user_assert with an error message, because a user might actually try to call a default-constructed callable
abadams
approved these changes
Feb 27, 2023
steven-johnson
added a commit
that referenced
this pull request
Feb 28, 2023
steven-johnson
added a commit
that referenced
this pull request
Mar 1, 2023
* Make Callable::call_argv_fast public (#7315) * Make Callable::call_argv_fast public * Add rough specification of the calling convention * Fix a typo * Add Callable default ctor + `defined()` method (#7380) * Add Callable default ctor + `defined()` method This allows it to behave like * Add user_assert + test --------- Co-authored-by: Tom Westerhout <14264576+twesterhout@users.noreply.github.com>
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Add Callable default ctor + `defined()` method This allows it to behave like * Add user_assert + test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to behave like other Halide IR pieces.