Skip to content

refactor: optimize the drag-and-drop performance #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 30, 2025
Merged

refactor: optimize the drag-and-drop performance #7601

merged 5 commits into from
Jun 30, 2025

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 27, 2025 •
edited
Loading

What type of PR is this?

/kind importment
/area editor
/milestone 2.21.x

What this PR does / why we need it:

为默认编辑器拖拽事件增加节流，解决部分由于鼠标移动事件所产生的性能损耗。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 27, 2025

@LIlGG: The label(s) kind/importment cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind importment

What this PR does / why we need it:

为默认编辑器拖拽事件增加节流，解决部分由于鼠标移动事件所产生的性能损耗。

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 27, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby June 27, 2025 10:22
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 27, 2025 •
edited
Loading

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7601

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7601

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7601

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7601

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7601

commit: e37006a

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (42c374d) to head (e37006a).
Report is 89 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7601      +/-   ##
============================================
+ Coverage     59.55%   59.64%   +0.08%     
+ Complexity     3812     3788      -24     
============================================
  Files           677      676       -1     
  Lines         23248    23077     -171     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13764      -82     
+ Misses         8764     8678      -86     
+ Partials        638      635       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ruibaby
ruibaby requested changes Jun 28, 2025
View reviewed changes
@LIlGG LIlGG requested a review from ruibaby June 30, 2025 02:35
@ruibaby ruibaby changed the title pref: optimize the drag-and-drop performance refactor: optimize the drag-and-drop performance Jun 30, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ruibaby
ruibaby approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2025
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 1ac665f into halo-dev:main Jun 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LIlGG @ruibaby