Skip to content

feat: add stack widget for dashboard #7525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2025
Merged

feat: add stack widget for dashboard #7525

merged 4 commits into from
Jun 9, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 9, 2025 •
edited
Loading

What type of PR is this?

/area ui
/kind feautre
/milestone 2.21.x

What this PR does / why we need it:

This PR adds a core Dashboard Widget called Stack Widget, which is used to stack a batch of components in the same location and supports manual or automatic switching.

image image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

为仪表盘添加堆叠小部件

@ruibaby
feat: add stack widget for dashboard
0dd303c 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 9, 2025
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 9, 2025

@ruibaby: The label(s) kind/feautre cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/area ui
/kind feautre
/milestone 2.21.x

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG June 9, 2025 10:13
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 9, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (42c374d) to head (b088d79).
Report is 37 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7525      +/-   ##
============================================
- Coverage     59.55%   59.46%   -0.10%     
+ Complexity     3812     3774      -38     
============================================
  Files           677      677              
  Lines         23248    23090     -158     
  Branches       1500     1482      -18     
============================================
- Hits          13846    13731     -115     
+ Misses         8764     8728      -36     
+ Partials        638      631       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ruibaby added 3 commits June 9, 2025 18:28
@ruibaby
Improve ux
f87886c 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Improve ux
f02fff5 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Refine i18n
b088d79 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 9, 2025
@ruibaby ruibaby changed the title WIP: feat: add stack widget for dashboard feat: add stack widget for dashboard Jun 9, 2025
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2025
@ruibaby ruibaby requested a review from JohnNiang June 9, 2025 13:37
JohnNiang
JohnNiang approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 3150734 into halo-dev:main Jun 9, 2025
9 checks passed
JohnNiang
JohnNiang reviewed Jun 9, 2025
View reviewed changes
ui/src/locales/_missing_translations_es.yaml
auto_play:
label: Auto play
auto_play_interval:
label: Auto play interval
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不过建议说明一下间隔时间单位：毫秒。

@ruibaby ruibaby modified the milestones: 2.21.x, 2.21.0 Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ruibaby @JohnNiang