Skip to content

feat: add iframe widget for dashboard #7516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2025
Merged

feat: add iframe widget for dashboard #7516

merged 3 commits into from
Jun 9, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 8, 2025

What type of PR is this?

/area ui
/kind feature
/milestone 2.21.x

What this PR does / why we need it:

Add iframe widget for dashboard

image

Does this PR introduce a user-facing change?

为仪表盘添加网页嵌入小部件

@ruibaby
feat: add iframe widget for dashboard
cda0729 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 8, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 8, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen June 8, 2025 06:40
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 8, 2025
@ruibaby
Copy link
Member Author

ruibaby commented Jun 8, 2025

/hold

Need to wait for #7511 to be merged.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2025
@ruibaby
Copy link
Member Author

ruibaby commented Jun 9, 2025

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JohnNiang
JohnNiang approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.61%. Comparing base (42c374d) to head (b15dc8f).
Report is 49 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7516      +/-   ##
============================================
+ Coverage     59.55%   59.61%   +0.05%     
+ Complexity     3812     3802      -10     
============================================
  Files           677      678       +1     
  Lines         23248    23193      -55     
  Branches       1500     1487      -13     
============================================
- Hits          13846    13827      -19     
+ Misses         8764     8730      -34     
+ Partials        638      636       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@f2c-ci-robot f2c-ci-robot bot merged commit 2332e09 into halo-dev:main Jun 9, 2025
9 checks passed
@ruibaby ruibaby modified the milestones: 2.21.x, 2.21.0 Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ruibaby @JohnNiang