Skip to content

feat: refine i18n for dashboard widgets config form #7511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 7, 2025

What type of PR is this?

/area ui
/kind improvement
/milestone 2.21.x

What this PR does / why we need it:

Refine i18n for dashboard widgets config form.

Which issue(s) this PR fixes:

Fixes #7508

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/ui Issues or PRs related to the Halo UI labels Jun 7, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 7, 2025
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing June 7, 2025 04:14
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 7, 2025
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang June 7, 2025 04:14
Copy link

pkg-pr-new bot commented Jun 7, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7511

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7511

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7511

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7511

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7511

commit: 73a3277

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.61%. Comparing base (42c374d) to head (73a3277).
Report is 45 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7511      +/-   ##
============================================
+ Coverage     59.55%   59.61%   +0.05%     
+ Complexity     3812     3802      -10     
============================================
  Files           677      678       +1     
  Lines         23248    23193      -55     
  Branches       1500     1487      -13     
============================================
- Hits          13846    13827      -19     
+ Misses         8764     8730      -34     
+ Partials        638      636       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Jun 9, 2025

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025
Copy link

f2c-ci-robot bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 4093435 into halo-dev:main Jun 9, 2025
11 checks passed
@ruibaby ruibaby modified the milestones: 2.21.x, 2.21.0 Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

编辑仪表盘 保存无提示,容易误解保存没有成功
2 participants