Add support for customizing nofollow of links in editor #7444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JohnNiang
requested changes
May 19, 2025
JohnNiang
reviewed
May 19, 2025
There was a problem hiding this comment.
Pull Request Overview
Adds a configurable “nofollow” option for links in the editor UI.
- Introduce a checkbox to toggle
rel="nofollow"on links. - Update the Link extension to set default
relattributes and render HTML accordingly. - Add a Chinese locale entry for the new “nofollow” label.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ui/packages/editor/src/locales/zh-CN.yaml | Added nofollow translation key |
| ui/packages/editor/src/extensions/link/index.ts | Set default rel to "noopener noreferrer" and added renderHTML |
| ui/packages/editor/src/extensions/link/LinkBubbleButton.vue | Added rel computed prop, checkbox UI, and integrated rel in setLink |
@halo-dev/api-client
@halo-dev/components
@halo-dev/console-shared
@halo-dev/richtext-editor
@halo-dev/ui-plugin-bundler-kit
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7444 +/- ##
============================================
+ Coverage 59.44% 59.54% +0.10%
+ Complexity 4142 3811 -331
============================================
Files 701 677 -24
Lines 24014 23248 -766
Branches 1543 1500 -43
============================================
- Hits 14274 13844 -430
+ Misses 9078 8765 -313
+ Partials 662 639 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ping @LIlGG Please help Review |
Co-authored-by: Takagi <mail@e.lixingyong.com>
Co-authored-by: Takagi <mail@e.lixingyong.com>
|
JohnNiang
approved these changes
May 26, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, LIlGG, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
May 26, 2025
#### What type of PR is this? /kind improvement /area editor /milestone 2.21.x #### What this PR does / why we need it: Improve English translations for the editor. The changes in #7444 did not provide English translations. #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area ui
/area editor
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #6950